Remove the unnecessary braces around From implementations. about modular-bitfield HOT 1 OPEN

Some possible solutions might be:

1. Add an #[allow(unused_braces)] attribute to the generated implementations.
2. Remove the block and quote only the expression in expand_repr_from_impls_and_checks.
3. Remove the block directly in generate_bitfield_size, and reinstate the block locally where it is required.

Solution 3 is what I would consider, albeit it requires knowledge of where blocks are needed and might require some code to discern between an actual sum and a value.

For example, if 3 was to be implemented sloppily, the following code would not work anymore:

#[bitfield]
struct Foo {
   bar: B16,
   baz: B16,
}

As the code generated in impl::bitfield::expand::generate_filled_check_for_aligned_bits would be incorrectly parenthesized.

This can easily be solved locally by parenthesizing the expression itself, knowing that a 0-fields bitfield cannot exist and that the format of generate_bitfield_size has, hence, always at least 2 addends, as follows:

fn generate_filled_check_for_aligned_bits(&self, config: &Config) -> TokenStream2 {
[...]
    type Size = ::modular_bitfield::private::checks::TotalSize<[(); (#actual_bits) % 8usize]>;
[...]

Similar cases may exist but they should be findable by tracing the uses of generate_bitfield_size.

from modular-bitfield.