Code Monkey home page Code Monkey logo

Comments (9)

rustatian avatar rustatian commented on June 1, 2024 1

Thanks @dmitryuk ๐Ÿ‘
All PRs are merged ๐Ÿ˜ƒ

from roadrunner.

rustatian avatar rustatian commented on June 1, 2024

Hey @dmitryuk ๐Ÿ‘‹
Why is it hard to monitor?

from roadrunner.

dmitryuk avatar dmitryuk commented on June 1, 2024

Because elapsed can have different units (ms, s, m). Logging system like ELK hard to interpreter it

from roadrunner.

dmitryuk avatar dmitryuk commented on June 1, 2024

@rustatian If I make a PR to always cast elapsed timestamp to ms units will you accept it?

from roadrunner.

rustatian avatar rustatian commented on June 1, 2024

@dmitryuk No need to cast, time might be written in ms natively. Sure, you may send a PR, but this elapsed time should be updated across the whole plugin.

from roadrunner.

dmitryuk avatar dmitryuk commented on June 1, 2024

MR 1 roadrunner-server/http#199
MR 2 roadrunner-server/jobs#125
MR 3 roadrunner-server/grpc#132
MR 4 roadrunner-server/kafka#339
MR 5 roadrunner-server/amqp#121
MR 6 roadrunner-server/nats#118
MR 7 roadrunner-server/boltdb#109
MR 8 roadrunner-server/beanstalk#103
MR 9 roadrunner-server/sqs#398

Ready for review

from roadrunner.

rustatian avatar rustatian commented on June 1, 2024

Cool, thanks @dmitryuk ๐Ÿ‘

from roadrunner.

rustatian avatar rustatian commented on June 1, 2024

@dmitryuk Please, rebase your PR's with master. There were some tests are failed, I've fixed that.

from roadrunner.

dmitryuk avatar dmitryuk commented on June 1, 2024

@rustatian done, thanks

from roadrunner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.