[Android] SymbolLayer not working in release mode / black in debug mode about maps HOT 3 CLOSED

In release mode the addImage method of RCTMGLStyle returns without downloading the asset. The reason is that RCTMGLStyleValue's shouldAddImage always returns false.

We have:

public boolean shouldAddImage() {
    return isAddImage;
}

isAddImage = imageURI != null && imageURI.contains("://");

But the image uri would fulfil the condition only in debug mode as it is of the following form:

• debug: "http://10.0.2.2:8081/assets/src/img/image.png?platform=android&hash=6b83f13973da21d525cf33f4c1b17a45"
• release: "src_img_image"

Applying this change fixes the problem, but it might introduce other flaws

- isAddImage = imageURI != null && imageURI.contains("://");
+ isAddImage = imageURI != null;

Concerning the asset rendering in black, it happens only within the simulator for me. It's probably a totally different issue.

from maps.

FYI, emulator GL rendering can be quite flaky depending on underlying hardware and emulator in use. I suggest you check that against a real device.

from maps.

@alexisrougnant Thanks, yes not sure why is the imageURI.contains("://") condition there. ImageURI can be a path, uri, bundled image name and maybe base64 images, but in any case we want to decode it.

Regarding the black icon, it works fine for me in android simulator. Not sure what's going on in that case for you. The image is clearly loaded just the colors are screwed up.

from maps.