Code Monkey home page Code Monkey logo

Comments (3)

rmp135 avatar rmp135 commented on September 6, 2024 3

Thinking about it, you've convinced me.

Given the following different column null / default configurations.

NullableWithDefault
NullableWithoutDefault
NotNullableWithDefault 
NotNullableWithoutDefault

Should output the following

NullableWithDefault?: string | null
NullableWithoutDefault? : string | null
NotNullableWithDefault?: string
NotNullableWithoutDefault: string

Essentially null acts like a default and the only instance in which a column isn't optional is when it's not nullable and there's no default value.

I've gone through and updated all dialects to work as above, fixing a couple of bugs along the way. Hopefully be able to get it out within a day or so.

from sql-ts.

rmp135 avatar rmp135 commented on September 6, 2024 2

This is fixed in version 1.10.0. All clients have had their optionality and nullability standardised as per the above.

from sql-ts.

sam-outschool avatar sam-outschool commented on September 6, 2024

I agree that nullable columns should "default" to null without another explicit default. Omitting the value on insert in SQL would result in the value being null, and query builders like knex have the same interface.

from sql-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.