Support Laravel 4.2 about laravel-js-localization HOT 16 CLOSED

I think that isn't necessary. You just need to follow the http://semver.org.

Make a branch to each "major.minor" version. The master branch would be the latest stable version, develop would be ... you know...

Mentions: @rmariuzzo @manuel-huez @gpopoteur @xAockd @okaufmann .

from laravel-js-localization.

That is true, all tags supports 4.1, 5.0 and now 5.1.
@rmariuzzo

from laravel-js-localization.

@manuel-huez you should use that version:

"require":{
    "mariuzzo/laravel-js-localization":"dev-master#242fc0500f633e2817e7e255f0d84b36407ffd73"
}

from laravel-js-localization.

This version produces the exact same problem @rmariuzzo @vluzrmos

from laravel-js-localization.

@rmariuzzo @vluzrmos Actually, This version isn't producing the problem, but the way of composer to handle this kind of dependency is. When specifying a specific version, composer is still loading the composer.json from the HEAD, and therefor reading the 5.* dependency.

Would you mind updating composer.json?

from laravel-js-localization.

@manuel-huez thanks for filing an issue about this. Unfortunately, looks like I accidentally broken the support for Laravel 4.2.x with one of my latest commits trying to fix the tests.

I would like your inputs on this. How should we deal properly with multi-version support?

I was thinking on using new versioning system that would follow Laravel Framework versions such as:

• Laravel 4.2 ➡️ rmariuzzo/laravel-js-localization#4.2.*
• Laravel 5.0 ➡️ rmariuzzo/laravel-js-localization#5.0.*
• Laravel 5.1 ➡️ rmariuzzo/laravel-js-localization#5.1.*

What do you think? @manuel-huez @vluzrmos @gpopoteur @xAockd @okaufmann

I will highly appreciate your input on this, also, let's have chat to create a “collaborator” team, have a roadmap and so on. I'm open to all suggestions and/or ideas

from laravel-js-localization.

Yup, creating a branch for each stable version tends to be the trend these
days.

On Saturday, July 4, 2015, Vagner Luz do Carmo [email protected]
wrote:

I think that isn't necessary. You just need to follow the
http://semver.org.

Make a branch to each "major.minor" version. The master branch would be
the latest stable version, develop would be ... you know...

Mentions: @rmariuzzo https://github.com/rmariuzzo @manuel-huez
https://github.com/manuel-huez @gpopoteur https://github.com/gpopoteur
@xAockd https://github.com/xAockd @okaufmann
https://github.com/okaufmann .

—
Reply to this email directly or view it on GitHub
#24 (comment)
.

from laravel-js-localization.

Everything said. It's my opinion too

from laravel-js-localization.

If would be nice to provide a version that supports Laravel 4.2 even if it's a quick fix for now. As for versioning, I guess SemVer is the way to go.
Thanks!

from laravel-js-localization.

Yup, it would be nice if you guys could tag the commit 242fc05. That's really all you need to do :)

from laravel-js-localization.

Cool! I will address this in a few hours.
On Jul 5, 2015 10:40 AM, "Manuel Huez" [email protected] wrote:

Yup, it would be nice if you guys could tag the commit 242fc05
242fc05.
That's really all you need to do :)

—
Reply to this email directly or view it on GitHub
#24 (comment)
.

from laravel-js-localization.

Any progress in this question?

from laravel-js-localization.

Any progress in this issue? I'm needing so much of this package, but i use laravel 4.2

from laravel-js-localization.

To be honest, I won’t get time until the weekend. I’m sorry to say that, but I don’t want keep saying that I will check it later. This weekend I will definitively work around and take down those issues. Thanks for sharing your interest on this.

On Jan 6, 2016, at 10:26, Bruno-Louvem [email protected] wrote:

Any progress in this issue? I'm needing so much of this package, but i use laravel 4.2

—
Reply to this email directly or view it on GitHub #24 (comment).

from laravel-js-localization.

Working on this right now!

from laravel-js-localization.

This will be released this week under v1.3.0.

from laravel-js-localization.