Code Monkey home page Code Monkey logo

Comments (13)

rm-hull avatar rm-hull commented on May 27, 2024 1

Will try to do this in the next few days

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024 1

@rm-hull there's a util called rstcheck that validates rst documents.

pip install rstcheck

And that gives an error for the README:

$ rstcheck README.rst 
README.rst:2: (WARNING/2) Duplicate explicit target name: "datasheet".

It's very likely that Pypi chokes on this. I'll create a PR with a fix. Note that there's a Pypi test site as well that you can use to preview the package documentation and usage.

from luma.oled.

rm-hull avatar rm-hull commented on May 27, 2024 1

yay! https://testpypi.python.org/pypi?:action=display&name=ssd1306&version=0.3.1

travis task would be 👍
test could be interesting... I guess a mock SMBus object would be all that is needed

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024 1

@rm-hull this looks promising: https://github.com/TCAllen07/raspi-device-mocks

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024 1

Also just noticed that the distributed tar.gz file does not contain the examples, docs, license etc.

$ ls -l ssd1306-0.3.1/
-rw-r--r--  1 foo  wheel  11595 13 nov 23:25 PKG-INFO
drwxr-xr-x  5 foo  wheel    170 13 nov 23:25 oled
-rw-r--r--  1 foo  wheel   1009 13 nov 23:24 setup.py

I think it would be good to include these assets since the average rpi user would get confused by this IMO. I'll include it in the upcoming PR.

And more importantly, setup.py has a dependency on README.rst; without that file installation using pip isn't even possible.

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024

requirements.txt shouldn't be necessary if you define the dependencies in setup.py..

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024

Any news?

from luma.oled.

rm-hull avatar rm-hull commented on May 27, 2024

Hi @thijstriemstra, I just published SSD1306 (0.3.0) to pypi for the first time (see https://pypi.python.org/pypi/ssd1306/0.3.0) .. do you know why the README.rst is not rendering?

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024

@rm-hull hmm that's odd.. I'll look into it.

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024

Having a travis task that checks for these doc mistakes would be nice as well. I'll see if I can add one. Also a good starting point for introducing tests at some point...

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024

Ok, the task is an improvement but it doesnt run the docs task yet under travis, will look into that. it also uses a really old pip version, will update that in the build as well.

from luma.oled.

thijstriemstra avatar thijstriemstra commented on May 27, 2024

I see https://pypi.python.org/pypi/ssd1306/0.3.1 but when I pip install it, it's still using 0.3 (and failing with the missing README.rst error).

from luma.oled.

rm-hull avatar rm-hull commented on May 27, 2024

Ok, 0.3.2 just published, and I was able to pip install it

from luma.oled.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.