Row/column height seems not to work about pdfjs HOT 28 CLOSED

I've pushed a minHeight option today
@chadRoberge Since those are features I am not needing for my own use-case, no ETA, sorry

from pdfjs.

Tables do not support fixed heights, yet :-/

from pdfjs.

@rkusa any way I can help to land that feature?

from pdfjs.

@knownasilya Yes, tell me how you'd expect the fixed height to work. E.g. should the last row take the remaining space, or should the rows be distributed among the fixed height, and how should content bigger than the fixed height be handled?

from pdfjs.

cc @ismyrnow

from pdfjs.

@rkusa seems like if the table height is set, the last row should fill i the remaining height, otherwise just use the height set.

If content overflows it should probably be hidden, since you are setting a fixed height.

from pdfjs.

I took a look at how HTML and in comparison Pages and Word handle these situations. All three distribute the height among their rows and the height cannot be smaller than the content.

@knownasilya May I ask what your use case for a fixed height table in a PDF is?

from pdfjs.

@rkusa generating mailing labels, which come in specific sizes, since they are pre-cut stickers.

from pdfjs.

That is, you'll also need some kind of vertical alignment option, doesn't you?

from pdfjs.

Not sure, but we could just start an implementation and see what's needed from there. Make it iterative, or just good enough for 1.0 and gain use cases for 2.0

from pdfjs.

I've added a height option for rows and cells. A height option for the whole table is still on my todo

from pdfjs.

Nice, I'll give it a try

from pdfjs.

So that works, but if the content goes outside of the height it breaks the heights..

from pdfjs.

@schurb Yes, imitates the behaviour found in HTML, Word, Pages, ... for your use case there is probably the need of an CSS overflow equivalent. I'll have a look ...

from pdfjs.

@rkusa I think you mean @knownasilya :)

from pdfjs.

Haha... note to myself: dont answer issues before the first coffee ☕

from pdfjs.

Jep, such a universal rule ☕

from pdfjs.

Haha, and here I go breaking it.

from pdfjs.

I've started to implement the overflow: hidden option. Example:

  var table = doc.table({
    borderWidth: 1,
    borderColor: 0xdddddd,
    padding: 10,
    widths: [200]
  })

  var tr = table.tr({ height: 220, overflow: 'hidden' })
  tr.td(fixtures.lorem.short)

It is not well tested, yet. However, if you don't mind, it would be nice if you could test it against your usecase.

from pdfjs.

2.0.0-alpha.1 has a feature regression here, both height and overflow have to be re-implemented

from pdfjs.

Was this fixed in 2.0 release? Or still for 2.1?

from pdfjs.

Still for 2.1, sorry 😔

from pdfjs.

Wait so height doesn't work now as well? If so I might not be able to update to 2.0 yet, aww..

from pdfjs.

Yes, height does not work as well. If 1.x works fine for you, I don't think you are missing out one something with 2.0, yet

from pdfjs.

Looking to use this library to generate checks, will also need the fixed height, and looking forward to it. There a time frame for 2.1?

from pdfjs.

What's the status here? Does minHeight replace what height used to be? What about overflow?

from pdfjs.

@knownasilya I still have it in the back of my mind, but no update yet, I am afraid.

from pdfjs.

Would love to get both of these back. Finally upgraded due to node versions, but now having issues due to both of these missing.

from pdfjs.