Open git-coauthors file from sidebar doesn't work on Windows about git-mob-vs-code HOT 11 CLOSED

I've tried it on MAC OS and works fine. So there is no need to remove the drive letter.
I'll get this fix out soon.

from git-mob-vs-code.

Interesting, I specifically remove the drive letter to make ti work on Windows

• Commit
• Current test file

I think the difference being you run the portable VS code version. I wonder if that has anything to do with it.
I'll try to find time to investigate it.

from git-mob-vs-code.

@r15ch13 I've setup Git Mob on a portable version of VS Code and was able to open the .git-coauthors file.

Were you able to follow the path in the error message to the file? I'm just wondering if the path is incorrect somehow?

By chance are you using the environment variable GITMOB_COAUTHORS_PATH?

from git-mob-vs-code.

The path itself is correct, except the missing drive letter. GITMOB_COAUTHORS_PATH is not set.

It works just fine if I remove .replace(/^([a-z]:[\\]|[\/])/gi, "") from

from git-mob-vs-code.

Example output:

  get path() {

    vscode.window.showErrorMessage("without regex: " + path.join(os.homedir(), this.file));
    vscode.window.showErrorMessage("with regex: " + path.join(os.homedir(), this.file).replace(/^([a-z]:[\\]|[\/])/gi, ""));

    return path
      .join(os.homedir(), this.file);
  }

from git-mob-vs-code.

Interesting, I'm on windows 10 and used the latest version of git-mob, git-mob-vs-code and VS Code.

The only thing I don't know is what version of VS Code do you have?

As far as I understand Portable VS Code, it does not auto-update. Maybe that version does not support file paths in the same way as the latest.

from git-mob-vs-code.

Installed via Scoop to D:\scoop\apps\vscode-portable\current

from git-mob-vs-code.

I see, the issue could be that is looking for .git-coauthors on your D drive but it's on your C drive.

This is easy to fix for windows, just need to think about Unix based systems.

from git-mob-vs-code.

Shouldn't be os.homedir() enough? The directory separators are correct in both cases.

const os = require('os')
const path = require('path')

console.log(path.join(os.homedir(), '.git-coauthors'))

Test in Ubuntu WSL

from git-mob-vs-code.

I remember the issue was on a Mac. So I'll need to confirm the path on a Mac.

When I first did this, I thought os.homedir() was the solution.

from git-mob-vs-code.

Will be part of release 1.3

from git-mob-vs-code.