Comments (6)
If I sent a pull request that implemented Fieldset which acts like Form but without the form specifics, would it be accepted (assuming all contributing guidelines is followed)?
If usage remains backward compatible and the code is good, definitely yes :)
from react-jsonschema-form.
If I sent a pull request that implemented Fieldset
which acts like Form
but without the form specifics, would it be accepted (assuming all contributing guidelines is followed)?
from react-jsonschema-form.
why don't you just use the component SchemaField
?
Checkout how it is being used here: https://github.com/mozilla-services/react-jsonschema-form/blob/master/src/components/Form.js
from react-jsonschema-form.
Yes, I ended up using SchemaField
and copying over all the Form
methods except onSubmit
. As to why not to do this: it is not DRY. Trying to factor out the common logic to another component either meant inheriting the common component or rendering a new sub-component which broke allot of unit tests that do internal state checks.
from react-jsonschema-form.
Any update on the best approach to this? Would like to drop a react-jsonschema-form powered fieldset into an existing form.
from react-jsonschema-form.
This was fixed by #1345!
from react-jsonschema-form.
Related Issues (20)
- New `enumTitles` not working => old `enumNames` have warnings ⚠️ that are depreciated 🐛 HOT 2
- Possibilty to filter properties from big json schemas HOT 2
- Allow defining custom validation error HOT 4
- Is it possible to clear form errors programatically? HOT 2
- Crash when update to v5.17.0: util could not be found within the project or in these directories HOT 5
- Consider moving omit extra data functionality to schemaUtils HOT 1
- Unable to create precompiled validators due to compileSchemaValidators HOT 2
- SSR and dependencies sections cause hydration errors. HOT 1
- setting options via ui:widget object is no longer supported, use ui:options instead HOT 3
- <>
- `Form` renders extra fields that breaks validation HOT 1
- If/then/else shows a field despite dependent condition not met HOT 2
- Bug with array properties inside allOf HOT 1
- Pass errorSchema from ArrayField to ArrayFieldTemplate HOT 2
- doc about localization of ajv incomplete for MUI forms HOT 4
- <title> disable SUBMIT button when no changes AND handle units of measure HOT 1
- Urgent help with populating an enum/oneOf with the key values of an array/object map HOT 4
- Is there a complete example for custom field & widgets? HOT 1
- Ability to disable $ref resolution HOT 2
- Passing required as part of the schema without using the built-in errors HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-jsonschema-form.