Code Monkey home page Code Monkey logo

Comments (6)

n1k0 avatar n1k0 commented on May 2, 2024 1

If I sent a pull request that implemented Fieldset which acts like Form but without the form specifics, would it be accepted (assuming all contributing guidelines is followed)?

If usage remains backward compatible and the code is good, definitely yes :)

from react-jsonschema-form.

zbyte64 avatar zbyte64 commented on May 2, 2024

If I sent a pull request that implemented Fieldset which acts like Form but without the form specifics, would it be accepted (assuming all contributing guidelines is followed)?

from react-jsonschema-form.

fermuch avatar fermuch commented on May 2, 2024

why don't you just use the component SchemaField?

Checkout how it is being used here: https://github.com/mozilla-services/react-jsonschema-form/blob/master/src/components/Form.js

from react-jsonschema-form.

zbyte64 avatar zbyte64 commented on May 2, 2024

Yes, I ended up using SchemaField and copying over all the Form methods except onSubmit. As to why not to do this: it is not DRY. Trying to factor out the common logic to another component either meant inheriting the common component or rendering a new sub-component which broke allot of unit tests that do internal state checks.

from react-jsonschema-form.

derekdon avatar derekdon commented on May 2, 2024

Any update on the best approach to this? Would like to drop a react-jsonschema-form powered fieldset into an existing form.

from react-jsonschema-form.

epicfaace avatar epicfaace commented on May 2, 2024

This was fixed by #1345!

from react-jsonschema-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.