preprocess error about svelte-loader-hot HOT 8 CLOSED

No, it should work the same. Looks like a bug, I'll try to see if I can reproduce. Any chance you can share your webpack config?

Have you tried with svelte-loader-hot, but the hot option set to false? Same result?

from svelte-loader-hot.

Here is the commit that I use to test svelte-loader-hot : wighawag/eip-2585@22f6281

for hot option you means the hotReload option ?

If so it still has the same issue

from svelte-loader-hot.

Hmm, I tried to add svelte-preprocess to my sapper template example and it seems to work.

In your project, you're missing the preprocess option in the client part of the config (here). It's probably needed there too.

If this doesn't help, can you share the error you're getting?

from svelte-loader-hot.

And yes, I meant the hotReload option sorry. Got confused with the Rollup plugin...

from svelte-loader-hot.

Yes, you right, it works : wighawag/eip-2585@1d95abd

Thanks!

I guess the client preprocess option was not needed in non-hot-reload mode because the css get generated once by the server and it never need to be generated again client side.
But with hot-reload it now need to be handled by client side for hot reload to work

The only issue I have now is that when I remove some css class definition, the css does not get updated, but if I change the value in the class definition, it get applied.

Not sure if this is solvable ?

from svelte-loader-hot.

I'm somewhat surprised that it works without the preprocess in the client, even with the official plugin. I don't know enough about tailwind and postcss to speculate as to why... But glad to hear you could make it work!

And yes, CSS is still badly supported. Simply put, Svelte adds some stylesheets to the document, and they are never removed. So when you change something, the change is visible (same CSS specificity, last appended stylesheet wins). But when you remove a CSS rule, it stays there forever...

Said like that it makes me realize that it is probably a sizable memory leak too (until you reload the page).

I have added a fix for this. Can you try with svelte-loader-hot@next (you should get 0.3.1-0), and see if it works better for you?

from svelte-loader-hot.

Yes seems like it works better. Could not test all the thing but I saw css update going through even when pre processed

from svelte-loader-hot.

I think we're done here. Feel free to reopen if needed.

from svelte-loader-hot.