Issue with how report/3 is called from login/base.ex:86 about phauxth HOT 5 CLOSED

Thanks for reporting this issue. I'll look into it and get back to you soon.

from phauxth.

I've added some changes to the master branch. I've made the report function overridable and updated the Confirm.Login module to use it. As you can see from the Confirm.Login example, it is not necessary to redefine all the report clauses - you just need to add your additional entries and then add an additional clause calling super on the arguments.

Let me know how that works and / or if you need any further information.

from phauxth.

Thank you very much. I will give some feed back once I get a chance to look into it. :)

from phauxth.

Nice so allowing for the override was what looks like needed to happen.

I made a simple example app showing how I'm trying to use a custom login module.
https://github.com/digitalcake/active_user_example_phauxth/blob/master/lib/active_user_example_phauxth/accounts/login.ex

Let me know if that is inline with your design you had for how people would extend that base login module. ("aside from extracting the reports & messages to its own module ect..")

So far it looks like it works. Thanks for the help again.

from phauxth.

I just updated the hex package with the new changes.

Thanks for showing me the example. I have just one comment to make. For the report fallback function, you just need one clause, like this:

def report(result, ok_message, meta) do
    super(result, ok_message, meta)
end

The pattern matching is then done by the default implementation. This is how the new version of the Confirm.Login module works.

from phauxth.