ritterim / build-scripts Goto Github PK

🔧 Enhancement Request

For symbol deployments to NuGet, it no longer supports the *.symbols.nupkg format—versus the "newer" *.snupkg-format.

To accommodate this requirement, we can either wait until Cake publishes the update that includes cake-build/cake#3331 or manually modify the cake-scripts to include ArgumentCustomization re;

Sample update

DotNetCorePack(clientProjectPath, new DotNetCorePackSettings
{
    Configuration = configuration,
    MSBuildSettings = new DotNetCoreMSBuildSettings().SetVersion(packageVersion),
    NoBuild = true,
    OutputDirectory = artifactsDir,
    IncludeSymbols = true,

    // New code...
    ArgumentCustomization = x => x.Append("-p:SymbolPackageFormat=snupkg")
});

Also ref. https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg

Who is asking for the feature?

@billbogaiv

What business problem is this hoping to solve?

Improve debug experience when using packages—we'll be able to see "source-code" variable names (versus compiled-names), etc.

🔧 Enhancement Request

• AddIn to calculate the version from version.txt combined with the CI build number
• AddIn to find the solution file

(Alternately, find existing addins for these.)

Who is asking for the feature?

RIMdev

What business problem is this hoping to solve?

Reduce the amount of code in some of the .cake files, with unit tests wrapped around them.

🔧 Enhancement Request

There's a newer .snupkgs file extension / format that we could be using instead.

https://blog.myget.org/post/2020/03/05/myget-nuget-symbols-snupkgs.html

Who is asking for the feature?

RIMdev

What business problem is this hoping to solve?

Provide debug symbols to the backend developers.

References

• Reason why we may not want to do this? We don't normally do "local feeds". Consuming snupkgs from local feed is not supported
• Microsoft: Creating symbol packages (.snupkg)
• The legacy (separate symbols package) is deprecated "The legacy format .symbols.nupkg is still supported but only for compatibility reasons (see Legacy Symbol Packages). NuGet.org's symbol server only accepts the new symbol package format - .snupkg." (ref: Creating symbol packages (.snupkg))

Suggested fix

from Creating symbol packages (.snupkg)

<PropertyGroup>
    <IncludeSymbols>true</IncludeSymbols>
    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

Note: This approach would require updating 8 or 9 projects that create Nuget packages. We may want to try and tackle it from the build script side first.