Comments (8)
Tjzabel
commented on May 30, 2024
1
I get that it is supposed to be strict, but it seems to be overly strict. We're testing out a threshold before CC declares code to be duplicates, which is where a lot of the issues seem to arise.
If this doesn't work we can always revert to what it's been doing.
from teleirc.
Tjzabel
commented on May 30, 2024
1
Are we okay with CC's limit of 25 lines per method? Would we want to raise this to 30, or consider a re-factor of all methods above 25?
from teleirc.
Tjzabel
commented on May 30, 2024
With commit 8931f1a, we should slowly see an increase in the CC grade.
CodeClimate is being a little too strict, so we hope to loosen up some of its checks to improve this.
from teleirc.
robbyoconnor
commented on May 30, 2024
That's kind of the point. It's supposed to be strict -- it's running a
linter.
…On 10/30/18 11:22 AM, Tim Zabel wrote:
With commit 8931f1a
<8931f1a>,
we should slowly see an increase in the CC grade.
CodeClimate is being a little too strict, so we hope to loosen up some
of its checks to improve this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABaMIN7nOeO20PLDYQcsshCJIDTHs2zks5uqG7QgaJpZM4Vvks3>.
from teleirc.
robbyoconnor
commented on May 30, 2024
You can customize things -- Code Climate allows you to make calls on
your own :)
…On 12/28/18 3:26 PM, Tim Zabel wrote:
Are we okay with CC's limit of 25 lines per method? Would we want to
raise this to 30, or consider a re-factor of all methods above 25?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABaMByIfWWAC8WJhnwGOUmt7QtmtI7oks5u9n6RgaJpZM4Vvks3>.
from teleirc.
jwflory
commented on May 30, 2024
@Tjzabel 30 lines over 25 lines feels like a harmless change. When I write code, I'm more liberal with breaking things across multiple lines anyways for the benefit of readability.
from teleirc.
robbyoconnor
commented on May 30, 2024
There are valid reasons for deviating from coding standards...do so with
good reason though.
…On 1/6/19 9:55 PM, Justin W. Flory wrote:
@Tjzabel <https://github.com/Tjzabel> 30 lines over 25 lines feels
like a harmless change. When I write code, I'm more liberal with
breaking things across multiple lines anyways for the benefit of
readability.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABaMJyw8kK12dtCttIoqUc5OUblxm26ks5vArcggaJpZM4Vvks3>.
from teleirc.
jwflory
commented on May 30, 2024
Since we are in the middle of rewriting the codebase (#163) and already have some issues open to discuss code style and best practices (#73, #207), I'm going to close this issue as wontfix for the time being. Once we ship the v2.0.0 release and figure out what tools we can use for code health, we can open a new issue to discuss this later.
Closing.
from teleirc.
Related Issues (20)
- Authorized... EOF... die HOT 5
- teleirc exits with code 0/success even on failure HOT 2
- Add an option for the bot to show the part/join messages for certain users
- Requires super-new glibc -- will not run on Debian HOT 4
- Spam prevention HOT 2
- ban evasion bug. user can pm the bot and send messages to irc without being in the group
- Add Arch Linux Mexico to the "Who uses TeleIRC?" page.
- RELAYMSG support when supported by the IRCd
- IRC ACTION statements do not appear on Telegram correctly
- Relay HOT 1
- Create unit tests for IRC action handler functionality
- teleirc's v2.2.0 does not provide a binary relase breaking the 'teleirc-bin' AUR package. HOT 3
- "SASL authentication failed" error message when attempting to connect to an IRC channel HOT 2
- SASL support to log into irc.libera.chat HOT 4
- teleirc shows the telegram nicknames in the Telegram with unneeded space HOT 2
- IRC Raw Log HOT 1
- IRC - TLS Client Certificates HOT 2
- IRC - Allow setting user modes HOT 2
- Cannot join registration-required channels HOT 3
- Relay announces own IRC join HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from teleirc.