Code Monkey home page Code Monkey logo

Comments (22)

alcir avatar alcir commented on May 30, 2024 1

I mean the variables you can see in node_modules/irc/lib/irc.js

from teleirc.

Tjzabel avatar Tjzabel commented on May 30, 2024 1

@jwflory thanks for the update! The end of the semester really is a messy time 🤣

from teleirc.

jwflory avatar jwflory commented on May 30, 2024 1

#150 addresses some of this issue, but not all of it. Before closing this issue, I would also like to hit these parts from irc.Client:

  • userName
  • realName
  • secure

I think these last configuration options, combined with #150, will be sufficient to address most users' needs.

from teleirc.

Tjzabel avatar Tjzabel commented on May 30, 2024 1

@jwflory I have a history of closing issues before fully realizing if they're done. I'll try to be better about that 😄

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

@alcir Currently there is not a way to specify these things in Teleirc. This is a good candidate issue for v1.4. We'll review issues for the next sprint once v1.3 is released.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Discussed in 2019-03-02 developer meeting.


This ticket was accepted for the v1.4 sprint.

We agreed this is a high-priority feature because it makes the bot more useful for more people. The implementation should be straightforward. I plan to work on this during the March sprint.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Uhh, actually @Tjzabel meant to close issue 112 with that commit, not this PR. Reopening.

from teleirc.

Tjzabel avatar Tjzabel commented on May 30, 2024

@jwflory thanks for the catch!

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Discussed in 2019-03-30 Teleirc developer meeting.


I plan to do research this week for this ticket. I hope to have an idea of what to include and change for this by the next developer meeting on April 6th. I hope to have a final implementation by April 13th. I left the final week open in case of delays before the end of the v1.4 window on April 20th.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Discussed during 2019-04-06 developer meeting.


I have no major updates yet. Still planning to get this done in the next week.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

I'm caught up in some of our other work for our new logo and planning our presence at the Imagine RIT festival this month. I suspect I will not have time to work on this before the end of the Spring 2019 semester, but I will try to do what I can.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Discussed in 2019-04-13 Teleirc developer meeting.


As discussed above, I chose to drop this ticket for this sprint since I need more bandwidth to prepare for Imagine RIT at the end of this month.

@nic-hartley finished #19. Next, he is researching this ticket to see if it is simple enough for him to work on before the end of the v1.3.1 sprint on Saturday, April 20th. If it is a quick fix, we'll get it into this release. If not, we'll push back to v1.4.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Discussed in 2019-04-20 developer meeting. Final developer meeting of the RIT Spring 2019 semester.


This ticket is dropped for the v1.3.1 sprint because we lacked team bandwidth to work on it leading up to university final exams. This ticket may be completed over the summer. More sprints may be planned for summer.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

See issue #145 from @diegoraf for the ident and realname fields set by the Node IRC library we use. It provides defaults of nodebot and nodeJS IRC client respectively, but we should override these and make them available to configure in our env.example file.

Also, when we do this, I would like to make our provided default config use teleirc for the ident and maybe TeleIRC bot (https://github.com/RITlug/teleirc) as the realname to make our project easier to find if someone doesn't care what these values are.

from teleirc.

Tjzabel avatar Tjzabel commented on May 30, 2024

Taken care of in PR #150 🎉 🎉

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

@Tjzabel No worries. I am equally guilty of doing the same at times too. 😂

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

@RITlug/teleirc-developers-commit-access Any thoughts on this from a v2.0.0 perspective?

from teleirc.

Tjzabel avatar Tjzabel commented on May 30, 2024

@jwflory I think having feature parity with where we currently stand is good enough. What other specific IRC features are part of the closing criteria? If they don't take a lot of time to implement, I am okay with adding this to the v2.0 release

from teleirc.

jwflory avatar jwflory commented on May 30, 2024
  • Metadata edited:
    • Milestone (v2.x.x ➡️ v2.1.0)

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Discussed in 2020-10-11 meeting.


I'm going to work on this one for this sprint. This will be my first code contribution to the v2 branch, and first time really getting into Go… so let's see where this goes. 😉

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

Fixed in Pull Request #355.

from teleirc.

jwflory avatar jwflory commented on May 30, 2024

@alcir Keep an eye out for this feature in v2.1.0 coming within the next week.

from teleirc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.