Accounts list is not updating about sossoldi HOT 4 CLOSED

Hi! If you want I can assign this issue to you while you try to figure out the root cause of the bug. Since the issue might go unnoticed for a bit if you want you can try asking the same question also in the Discord channel since it is a bit more active

from sossoldi.

Finally found it! It took me more than I would like to admit. But contrary to my first hunch, the issue was in the SQL query in the selectAll() method in BankAccountMethods.
This method launches an SQL query that looks something like this:

SELECT b.*, (b.startingValue +
      SUM(CASE WHEN t.type = 'IN' OR t.type = 'TRSF' AND t.idBankAccountTransfer = b.id THEN t.amount
               ELSE 0 END) -
      SUM(CASE WHEN t.type = 'OUT' OR t.type = 'TRSF' AND t.idBankAccount = b.id THEN t.amount
               ELSE 0 END)
    ) as total
      FROM bankAccount as b
      LEFT JOIN "transaction" as t ON t.idBankAccount = b.id OR t.idBankAccountTransfer = b.id
      WHERE active = 1 AND recurring = 0
      GROUP BY b.id
      ORDER BY createdAt AS

Now, focusing on the LEFT JOIN part of the query, you see that the WHERE clause filters out rows after the join is done, hence filtering out all bank accounts that have a transaction with the recurring field different from 0.
Practically speaking, if I add a new bank account that has no transactions (i.e. I add a row to the bankAccount table) this is correctly saved by the left join but is lost after it meets the WHERE clause.

Hopefully, I will fix it tomorrow!

from sossoldi.

This issue has already been fixed in #134, forgot to git pull and have been using an older version of the repo.

from sossoldi.

Good catch by the way!

from sossoldi.