Move function declarations to the top? about compiler HOT 7 CLOSED

I don't know much about the compiler changes, but I think it was (is?) useful in this case:

<my-tag>
  <div each={x in items}>
    <p>{getCount()}</p>
  </div>

  this.count = 0

  getCount() {
    this.count += 1
    return this.count
  }
</my-tag>

getCount gets called against the anonymous tag created by each. Without the bind, we'd update count on that anonymous tag, rather than my-tag.

from compiler.

If it's not too much of a pain, I'd agree that this should be consistent with javascript's normal hoisting behavior.

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function#Function_declaration_hoisting

from compiler.

Looks easy to implement it. Just inserting the function on top, instead of bottom of parts.
https://github.com/riot/compiler/blob/v2.5.3/lib/compiler.js#L413-L426

from compiler.

@cognitom you're right, It looks easy, this week...

EDIT: Of course, not so easy because https://github.com/riot/compiler/blob/v2.5.3/lib/compiler.js#L425

  if (toes5 && !/^\s*.\s*bind\b/.test(js)) parts.push('.bind(this)')

...and the output for the test.

from compiler.

btw, I was thinking the other day about the functions generated by the riotjs parser, ex. from:

func(){ blah }

to

this.func = function() { blah }.bind(this)

Is bind neccesary in this case?

So it was in the original compiler so I kept it, but it seems redundant. In my code I've never had a need for bind with functions declared that way as they are always called with the correct context.

@cognitom , @rogueg , If I'm not missing something maybe we can remove the bind in tmpl v3.

from compiler.

@rogueg I see now, thanks.

from compiler.

closing this issue as clear SRP violation. The riot compiler will convert your components avoiding to touch your original javascript, if you need any special js preprocessor you can rely on registerPreprocessor method

from compiler.