Comments (13)
@justinmchase , the output that I get seems correct, can you check it please?:
//src: test/specs/fixtures/svg.tag
riot.tag2('icon-heart',
'<svg viewbox="0 0 32 32" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="M16,28.261c0,0-14-7.926-14-17.046c0-9.356,13.159-10.399,14-0.454c1.011-9.938,14-8.903,14,0.454 C30,20.335,16,28.261,16,28.261z"></path> </svg>', '', '', function(opts) {
});
from compiler.
When I run it like that I am not seeing a problem either. We are specifically using gulp-riot
in our build to process the tags.
We are specifically using [email protected]
and [email protected]
.
I'm trying to find a more targeted repro for you.
from compiler.
I've attached a minimal reproduction of the issue.
repro-45.zip
Unzip then:
$ cd test
$ npm install
$ gulp good # success
$ gulp bad # hangs
You'll see that the good.tag
processes without error, as expected, but bad.tag
when run through the same pipeline causes gulp to hang, no error is produced, and no tag file is generated.
from compiler.
@justinmchase , this is a bug. Please use a previous riot version, I will fix this issue ASAP.
from compiler.
For anyone encountering this issue the workaround was to add "riot-compiler": "2.3.20"
to my main package.json
which causes it to use that version specifically.
from compiler.
Had this issue too, oof that was a hard one to track down...
To provide some content, this was causing webpack to hang with riotjs-loader, I have a tag with a svg in it as well.
from compiler.
The error is in a regex parsing quoted attribute values.
from compiler.
Please test with v2.3.22, it is already in npm.
from compiler.
Appears to work now, thanks @aMarCruz !!!
from compiler.
Works for me too. I'm closing this for now as fixed by #44
from compiler.
So unfortunately I had to revert back to 2.3.20 again because, while this seems to work at first it is still hanging our build. It does successfully generate the files and the compiler seems to work but it then hangs open our gulp process and it cannot be killed with Ctrl+c
.
Revertting back to the older version fixes the problem. I'm not totally sure but it seems like a callback may not be called in this situation.
from compiler.
Shoot false alarm, I think it's something else taht was masked by this problem after all. Sorry.
from compiler.
good to hear it.
from compiler.
Related Issues (20)
- [BUG]the compile(4.0.0-beta.5) should handle empty style or script node
- when tag with a namespace is defined, inline styling is not working HOT 2
- Unwanted characters are inserted when escaping CSS strings HOT 4
- Behaviour of value attribute HOT 17
- v4.3.6 Didn't get published on npm repository HOT 2
- createValueExpression::sourceNode.expressions is undefined
- Cannot access object property within template, key is not defined HOT 1
- Value on custom tags should be always passed down as prop
- Parse error when use stylus as css preprocessor HOT 2
- After version 4.4.3 (v4.5.0) an error occurs: string.trimStart is not a function HOT 3
- Emit compiler warning, if riot script tag is outside of root tag HOT 1
- ImportExpressions are not supported
- Asynchronous preprocessor HOT 4
- Wrong compilation for in parentheses expression HOT 2
- "src" attribute for <style> and <script> HOT 5
- Multiline Sourcemap Issues HOT 2
- Importing scss inside of riot component HOT 4
- template element related: generated style has incorrect selector; elements of template does not receive is= tagname to be selected HOT 2
- Inline object declarations in tags fail to compile in RiotJS ver 6; works in RiotJS ver 5. HOT 2
- Boolean attributes rendering should be enabled on custom elements as well only for certain attributes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compiler.