Code Monkey home page Code Monkey logo

Comments (2)

rionmonster avatar rionmonster commented on May 23, 2024

Hi @mnguyen284,

Thanks for reporting this.

The fix itself should be fairly straight-forward as the library already support the Entypo library, so it would just be a matter of explicitly targeting the Bootstrap themes via the GlyphCSSDefinitionExpression property of the provider. This would allow Entypo glyphs to be picked up by either Entypo or the Bootstrap themes explicitly.

The Bootstrap themes themselves are quite nice, however I always reserve a bit of hesitation regarding adding functionality to support a non-core library (i.e. not Entypo, but a library that uses Entypo) as it can lead to a slippery slope. I'll probably just build a custom provider for Bootstrap themes that points to the Entypo library, this way if things change in the future (i.e. they target a different icon set or their own custom one, changes will be minimal).

I'll throw together something for this when I have some time at lunch today.

from glyphfriend.

mnguyen284 avatar mnguyen284 commented on May 23, 2024

Hi,

Thanks for your respond. My workaround was taking the Entypo part from the theme css and put into entypo.css. Not elegant but it works.

Yeah I'm not suggesting you should support Bootstrap theme. It's a paid product, which means it's not accessible for everybody.

from glyphfriend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.