Comments (5)
Also, might I suggest making sure your solution to this issue be extendable enough so that it can be used for different code reviewing systems. So, maybe a way of allowing someone to provide the javascript for the place where you would swap or something like that. (I'm not good at Javascript or web dev at all, so I don't really know what I'm talking about ;))
from eject.
Excellent! I think the diff
use case is very compelling.
I believe that I take those 3 things into account though. Do you have an example that should be more readable? I don't have any direct test cases for this and may have introduced a regression.
from eject.
I actually only read your README; I hadn't looked through yet to see if you handled all of them. So if you do already, feel free to close the issue. I don't have a good example at the moment.
The thing that would be interesting is coming up with a way to integrate this into a code reviewing system so that you don't need to actually check in the swift file, but rather just see a diff of the generated code version alongside the XIB itself.
from eject.
Yea, that is interesting. The web app could be passed 2 file URLs and generate a diff. Then there could be a diff
button injected via javascript which would open my web app diff or do a div swap.
I like this idea, so I'm going to rename the issue to track this instead of closing it. Usually I move web app bugs over to EjectAssist
, but I'll keep this here for now since it may direct some Eject work.
If you could double check that the names are looking good to you, that'd be great.
from eject.
Ok. That sounds good. Yeah, I'll try to test this library when I can. Definitely looks interesting for diffing purposes to me.
from eject.
Related Issues (20)
- variable names should be inferred from IBOutlets
- Create homebrew formula for easy installation HOT 1
- Download button HOT 1
- Syntax Highlighting HOT 1
- Use Anchorage edge shorthand where possible HOT 3
- UIDatePicker minuteInterval error HOT 2
- Disable frame generation properly
- States! HOT 1
- License? HOT 1
- Add support for SnapKit HOT 1
- Enhance Code Generation Options
- Add CLI support for configuring code generation
- Fix UIVisualEffectView
- UIBarButtonItem should inject target/action
- UIStackView may out of order HOT 1
- LayoutMargins not generated HOT 1
- Readme add some badges
- Support Safe Area Layout Guide HOT 1
- eject fails to build with Xcode 11 (swift 3 is unsupported)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eject.