Comments (3)
@willzeng
I looked through the code and I think the problem has an upside and a downside.
-
On the upside: VQE only has functions of the form
f: list -> PyQuil.function
which is exactly what we want. Hence there is no direct dependency onpyquil.ParametricFunction
-
On the other hand
pyqaoa.qaoa
has a dependency on various parts odpyquil.Paulis
, which hence indirectly introduces a dependency toParametricFunctions
throughPaulis.exponential_map
that returns a decorated program.
As far as I can tell from a first pass Paulis.exponential_map
is the only point where we induce ParametricFunction
into grove. There is no direct import of ParametricFunction in the grove library (except some ipynb) and the name of parametric_state_evolve
is misleading. In this light it might be worthwhile to try and refactor Paulis
to purge the dependency. What's our thought?
cc @ncrubin as he wrote most of qaoa.py
according to the git annotate.
from grove.
Yep that's correct @jotterbach. As part of this issue exponential_map
should be changed to return a python function rather than a parametric program. I also agree that changed should be made to make function behavior clear if their output type has changed
from grove.
this was fixed by #32
from grove.
Related Issues (20)
- Add type annotations to grove modules
- Make grove documentation pyQuil 2.0 compatible
- Make VQE/QAOA/ising modules pyQuil 2.0 compatible
- Make example notebooks pyQuil 2.0 compatible
- DeutschJosza has no business being a class
- IsingSolver probably doesn't work with noise models
- Inconsistent energy in maxcut_qaoa depending on samples argument
- Implementation of weighted Max-cut
- Bug when minimizer_kwargs is empty but the minimizer is not optimize.minimize
- Bug in vqe_run when disp = True
- 'QVMConnection' object has no attribute 'run_and_measure_async'
- master/docs/qaoa.rst is almost unintelligible because markup is not rendered HOT 4
- VQE documentation is out of date with code HOT 1
- Release 1.8.0 (or 2.0.0).
- Phase Estimation wont return eigenvectors that correspond to the eigenvalue
- maxcut notebook is broke HOT 1
- Problem with the 'return_all' parameter in the 'vqe_run'
- import error 'get_devices' HOT 1
- VQE on QVM with noise model not compatible
- Numpy required for setup?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grove.