Modifications for latest material design and rxjs about feedback HOT 6 CLOSED

Hi @hakkurishian , the project is being upgraded with the newest version of angular, rxjs, etc. It should be completed before this sunday. Thanks.

from feedback.

Hi gordonmckenzie
Thanks for your attention. I will take some time to review your advice and code. If there is no issue i will update the code asap. BTW, it is better if you can make pull request so that I could try your code directly. Thanks again!

from feedback.

The project has been upgraded as advice of @gordonmckenzie . It could be running without issue. I will publish newest package to npm later. Thanks.

from feedback.

Further to the above, there is an issue regarding the final merge of the screenshotCanvas and the mergedCanvas. It might not be the prettiest solution, but I managed to get this to work using the following modification within feedback.dialog.component.ts: -

public mergeCanvas() { this.showToolbar = false; this.detector.detectChanges(); this.appendScreenshot(); let mergedCanvas = document.createElement('canvas'); let x; let y; let ctx = mergedCanvas.getContext('2d'); if (ctx === null) { return; } x = mergedCanvas.width; y = mergedCanvas.height; mergedCanvas.width = this.screenshotCanvas.width; mergedCanvas.height = this.screenshotCanvas.height; ctx.drawImage(this.screenshotCanvas, 0, 0); ctx.drawImage(this.drawCanvas, 0, 0); this.feedback.screenshot = mergedCanvas.toDataURL('image/png'); mergedCanvas.width = x; mergedCanvas.height = y; ctx.clearRect(0, 0, mergedCanvas.width, mergedCanvas.height); ctx.drawImage(this.screenshotCanvas, 0, 0, 360, 200); ctx.drawImage(this.drawCanvas, 0, 0, 360, 200); this.feedbackService.setCanvas(mergedCanvas); }

from feedback.

Hi gordonmckenzie
Thanks for your attention. I will take some time to review your advice and code. If there is no issue i will update the code asap. BTW, it is better if you can make pull request so that I could try your code directly. Thanks again!

@RickonChen did you manage to look into it? I'm planning to use this great module in my app using Angular 6.0. In case you didn't have the time yet and won't be able to integrate it in the latest version I'd try to implement @gordonmckenzie 's changes in a pull request.

from feedback.

The ng-feedback has been uploaded to npm and find no issue after testing.
https://www.npmjs.com/package/ng-feedback

from feedback.