Comments (5)
This module is designed to create a single task. Now that I think about it that way, your approach makes total sense.
from terraform-aws-alb-ecs-task.
hmm...Are we sure this is the approach we want to take?
I feel like logically it would make more sense to pass rules into the module than out of the module. If we really don't want to create the listener in the module, what advantage do we gain from creating rules in the module?
from terraform-aws-alb-ecs-task.
Yes. This approach has the advantage of being able to create a single listener that listens on 443 and routes requests to different ECS services depending on their host header like you'll see if you review my OF PR
from terraform-aws-alb-ecs-task.
Wouldn't you be able to do the same by passing a list of route objects into the module and using a for loop?
from terraform-aws-alb-ecs-task.
oh, my brain had the entirely wrong context in mind
from terraform-aws-alb-ecs-task.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-alb-ecs-task.