Code Monkey home page Code Monkey logo

Comments (11)

rhysd avatar rhysd commented on May 22, 2024 2

I'll upgrade the default version to v3.4 and will close this issue 👍

from vim-grammarous.

fncll avatar fncll commented on May 22, 2024 1

Have you any update on possibly using Grammarous with the more recent versions of LanguageTool?

from vim-grammarous.

rhysd avatar rhysd commented on May 22, 2024

OK, I'll fix it later.

But you can try to specify the URL of language-tool as below.

let g:grammarous#jar_url = 'http://path/to/your/favorite/language-tools.zip'

from vim-grammarous.

sgur avatar sgur commented on May 22, 2024

LanguageTool version 3.2 was released, too.

But this version requires Java 8.
I have no idea that which version is more suitable as default.

https://www.languagetool.org/download/LanguageTool-3.2.zip

from vim-grammarous.

rhysd avatar rhysd commented on May 22, 2024

Yes, I thought the same.

I must investigate which version is suitable for default value. At least OS X now uses Java8 by default.

from vim-grammarous.

tyru avatar tyru commented on May 22, 2024

@rhysd Maybe you can also determine which version is suitable by :if.
Abstract code is here:

let s:java_ver = matchstr(systemlist('java -version')[0], 'version "\zs.*\ze"')
if s:is_greater_than(s:java_ver, 1.8)
    let g:grammarous#jar_url = <LanguageTool 3.2>
elseif s:is_greater_than(s:java_ver, 1.7)
    let g:grammarous#jar_url = <LanguageTool 3.1>
else
    ...
endif

from vim-grammarous.

rhysd avatar rhysd commented on May 22, 2024

@tyru

I don't think Java version is problem (sorry for confusing). I think I can limit Java version >= 8 for vim-grammarous.

What I must investigate is that major version update (3.0) doesn't break vim-grammarous. If vim-grammarous can work with LanguageTool 3.0+, I will update the URL and update Java version requirement to 8.

from vim-grammarous.

rhysd avatar rhysd commented on May 22, 2024

Although default version is old, you can specify g:grammarous#jar_url to use latest version of LanguageTool. Did you try that?

from vim-grammarous.

sappo avatar sappo commented on May 22, 2024

Just specified latest languagetool jar url and everything works just fine!

from vim-grammarous.

rhysd avatar rhysd commented on May 22, 2024

@sappo

Thank you for the report. You mean v3.4?

from vim-grammarous.

sappo avatar sappo commented on May 22, 2024

Yes

from vim-grammarous.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.