Update to Node 10 about labs-ci-cd HOT 12 CLOSED

let's try to stick to product versions if we can @rdebeasi . Latest product versions are node.js 8. I suspect OCP 4 will ship node 10.

https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/openshift3/jenkins-agent-nodejs-8-rhel7

https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/rhscl/nodejs-8-rhel7

from labs-ci-cd.

ahhh I stand corrected. we now have two node.js distros sigh....

Looks like runtime supports 10 https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/rhoar-nodejs/nodejs-10, but jenkins does not yet.

from labs-ci-cd.

Gotcha - thanks for clearing that up! Is that something that could get updated in jenkins-slave-npm, or would we need to wait for OCP 4?

from labs-ci-cd.

I added you to a thread internally on this for context Ryan.

In short, it looks like updating CoP repos to run node 10 is the right approach. Yes we can do that, some one just needs to open an issue / PR over there.

from labs-ci-cd.

Awesome, thanks! Issue opened: redhat-cop/containers-quickstarts#181

from labs-ci-cd.

Looks like this change has been made upstream. Node 10 should be included in the next release of containers-quickstarts.

from labs-ci-cd.

Didn't I already do this? IIRC, I created a NodeJS 10/NPM 6+ container image based on what we created at DHS...

from labs-ci-cd.

redhat-cop/containers-quickstarts#137

from labs-ci-cd.

Thanks for calling that out! Yep, looks like that PR does include NodeJS 10 along with a some new security features. Feedback was submitted three weeks ago, and the PR is pending updates based on that feedback. Looking forward to seeing some npm audit coolness in there! 😄

The good news is that containers-quickstarts now includes Node 10 in master, and the changes that @pabrahamsson made should apply cleanly over yours.

The only remaining work in this labs-ci-cd issue is to wait for a new release of containers-quickstarts and bump the version number accordingly.

from labs-ci-cd.

Those requested changes were merged and submitted.

from labs-ci-cd.

https://github.com/redhat-cop/containers-quickstarts/tree/v1.7 now has this merged and tagged.

from labs-ci-cd.

Looks like we're now pointing to containers-quickstarts 1.9, which includes Node 10. Thank you, @InfoSec812, @haithamshahin333, and @sherl0cks !!!! 😄 🚀 🍕

from labs-ci-cd.