KSampler Config is no longer working for sampler_name since Oct 05 about rgthree-comfy HOT 7 OPEN

Interesting, maybe I can fix the disconnecting from my end while they figure out what they want to do with list types more broadly.

FWIW, I created an issue here: comfyanonymous/ComfyUI#1674

from rgthree-comfy.

Alright, reroute nodes shouldn't disconnect with the latest. Still have to connect ksampler first.. it's kind of a bug that it works, but I won't fix it for now until comfyui addresses the list types. :)

Keeping this open since it's not final.

from rgthree-comfy.

from rgthree-comfy.

Yea, looks like there's a lot of churn there in the type.. not sure what to do, they've broken it twice in 6fc7314 and then changed it again in b9b178b.

I think the place they'll end up is way better than what they had, but I'm not sure the current design takes anything into consideration that isn't the specific PrimitiveNode, which doesn't help this node (or any other node with list outputs)

from rgthree-comfy.

Found a workaround, if you use a reroute (rgthree) and connect it first to the KSampler for instance, and then to KSampler Config, you can use for the session. However, you lose the connection when you load a workflow.

from rgthree-comfy.

That would be awesome for now! Thank you!

from rgthree-comfy.

FaceDetailerPipe:
    - Return type mismatch between linked nodes: scheduler, ['normal', 'karras', 'exponential', 'sgm_uniform', 'simple', 'ddim_uniform'] != ['normal', 'karras', 'exponential', 'sgm_uniform', 'simple', 'ddim_uniform', 'AYS SDXL', 'AYS SD1', 'AYS SVD']

Source of the issue: https://github.com/ltdrdata/ComfyUI-Impact-Pack/blob/Main/modules/impact/core.py#L44
Commit: ltdrdata/ComfyUI-Impact-Pack@1b4b830

from rgthree-comfy.