Code Monkey home page Code Monkey logo

Comments (9)

rfoltyns avatar rfoltyns commented on June 19, 2024

Absolutely, I'd love to do that (if I had to). The thing is that - current client versions are compatible with all of the latest ES cluster releases.
(Please correct me if I'm wrong but)
log4j2-elasticsearch-jest works fine with 6.2.4 (I'll give you an update against 6.3.0 soon)
log4j2-elasticsearch5-bulkprocessor works fine with 5.x and 6.x
so, unless you have a feature request that requires the update, I feel really well with the versions that we're on ATM

from log4j2-elasticsearch.

kardapoltsev avatar kardapoltsev commented on June 19, 2024

Yes, it works but it brings unwanted dependencies to my project.

from log4j2-elasticsearch.

rfoltyns avatar rfoltyns commented on June 19, 2024

Ok, makes sense. I'll see what I can do.
Which module gives you trouble? And which dependencies you'd like to get rid of?

from log4j2-elasticsearch.

kardapoltsev avatar kardapoltsev commented on June 19, 2024

We are using elasticsearch client v6.x in our project. I didn't try to force client v6 dependency but it doesn't seem to be a right way to deal with it IMHO.

I'd like to use log4j2-elasticsearch5-bulkprocessor.

from log4j2-elasticsearch.

rfoltyns avatar rfoltyns commented on June 19, 2024

This is pretty nasty. Exclusion will not work as 5.6.9 and 6.x have incompatible client.addTransportAddress APIs. Plus, XPack requires more deps in provided scope since 6.3.0. There are a couple of options here:

  1. I can add log4j2-elasticsearch6-bulkprocessor in 1.2 release (coming soon) with dependency to 6.2.4 or later
  2. I can update the client to 6.x in log4j2-elasticsearch5-bulkprocessor - I'm not a fan of this, cause it will create similar problems to projects using client v5.x
  3. You could consider using log4j2-elasticsearch-jest in projects that use ES client v6.x as well

I'm leaning towards elasticsearch6 module, but what do you think about option 3 for now?

from log4j2-elasticsearch.

rfoltyns avatar rfoltyns commented on June 19, 2024

@kardapoltsev I've added log4j2-elasticsearch6-bulkprocessor with dependency to org.elasticsearch.client:transport:6.2.4. I'll release it next week.

Would you like to test it against 1.2.0-SNAPSHOT? If so, I'll put it in Maven repos over the weekend. As an alternative, you can build it yourself.

from log4j2-elasticsearch.

kardapoltsev avatar kardapoltsev commented on June 19, 2024

Sorry for the late response. Yes, I could test it if you still need it.

from log4j2-elasticsearch.

rfoltyns avatar rfoltyns commented on June 19, 2024

Yes, please. I've just released log4j2-elasticsearch6-bulkprocessor:1.2.0 with a dep to 6.2.4

from log4j2-elasticsearch.

kardapoltsev avatar kardapoltsev commented on June 19, 2024

Works for me, thanks.

from log4j2-elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.