Comments (6)
zaxasheats
commented on May 24, 2024
Actually it looks like any of the string based VRs would have the same issue.
from evil-dicom.
rexcardan
commented on May 24, 2024
I just made a unit test to do check this problem. It doesn't fail. I'm using the most recent Git repo (check the prerelease box in NuGet if thats what you are using to get the most up to date...don't know about v 2.0.0):
[TestClass]
public class CodeStringMultiplicityTests
{
[TestMethod]
public void CanAddMultipleStringsTest()
{
var dcm = new DICOMObject();
dcm.ReplaceOrAdd(DICOMForge.ImageType("Type1", "Type2", "Type3"));
var expected = 3;
var data = dcm.GetSelector().ImageType.Data_;
var actual = data.Count;
Assert.AreEqual(expected, actual);
Assert.AreEqual("Type1", data[0]);
Assert.AreEqual("Type2", data[1]);
Assert.AreEqual("Type3", data[2]);
}
}from evil-dicom.
zaxasheats
commented on May 24, 2024
It is fine in memory. When it gets written to disk it doesn't use the
multiplicity. It uses the first item only. Try the same test with a write
and a read in between.
Thanks, Matt
On Aug 9, 2017 11:18 AM, "Rex Cardan" <[email protected]> wrote:
I just made a unit test to do check this problem. It doesn't fail. I'm
using the most recent Git repo (don't know about v 2.0.0):
[TestClass]
public class CodeStringMultiplicityTests
{
[TestMethod]
public void CanAddMultipleStringsTest()
{
var dcm = new DICOMObject();
dcm.ReplaceOrAdd(DICOMForge.ImageType("Type1", "Type2", "Type3"));
var expected = 3;
var data = dcm.GetSelector().ImageType.Data_;
var actual = data.Count;
Assert.AreEqual(expected, actual);
Assert.AreEqual("Type1", data[0]);
Assert.AreEqual("Type2", data[1]);
Assert.AreEqual("Type3", data[2]);
}
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMs_B0d6KBdHfW-2OJN-6kP5V3_DSETHks5sWc3NgaJpZM4Ou1vT>
.
from evil-dicom.
rexcardan
commented on May 24, 2024
Interesting. I see the problem in the datacomposer class as well. I will patch today and update this thread when complete.
from evil-dicom.
zaxasheats
commented on May 24, 2024
Great!
Thanks, Matt
…On Aug 9, 2017 11:25 AM, "Rex Cardan" ***@***.***> wrote:
Interesting. I see the problem in the datacomposer class as well. I will
patch today and update this thread when complete.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMs_B014a5klwBv1KiioEPYiamVQhnblks5sWc9QgaJpZM4Ou1vT>
.
from evil-dicom.
rexcardan
commented on May 24, 2024
Well it is a little weird. I see why I made it like that. The DICOM standard is not really clear how those CodeString can have multiple values. But I did see the ImageType VM > 1 so I put it in. Not all string values can have multiple values (eg. LongText, ShortText, UniversalResourceId). Anyway, I did a first pass with it and I think it should work for you (NuGet v 2.0.0.5). Here is my new test.
[TestMethod]
public void CanAddMultipleStringsTest()
{
var dcm = new DICOMObject();
dcm.ReplaceOrAdd(DICOMForge.ImageType("Type1", "Type2", "Type3"));
//Memory test
var expected = 3;
var data = dcm.GetSelector().ImageType.Data_;
var actual = data.Count;
Assert.AreEqual(expected, actual);
Assert.AreEqual("Type1", data[0]);
Assert.AreEqual("Type2", data[1]);
Assert.AreEqual("Type3", data[2]);
var bytes = new byte[0];
//Test IO
using (var ms = new MemoryStream())
{
//WRITE
using (var bw = new DICOMBinaryWriter(ms))
{
DICOMObjectWriter.Write(bw, DICOMWriteSettings.Default(), dcm);
}
bytes = ms.ToArray();
}
//READ
var dcmRead = DICOMObject.Read(bytes);
expected = 3;
data = dcmRead.GetSelector().ImageType.Data_;
actual = data.Count;
Assert.AreEqual(expected, actual);
Assert.AreEqual("Type1", data[0]);
Assert.AreEqual("Type2", data[1]);
Assert.AreEqual("Type3", data[2]);
}from evil-dicom.
Related Issues (20)
- Feature Request: Single Association Mass CStore request
- Feature Request: Get (300A,000C) RTPlanGeometry Dicom tag HOT 1
- DICOM to BEV Transformation
- SendCStore skips important RS-DICOM-Tag (0008,0106) for Eclipse-Import
- Dicom File Larger than 2 GB HOT 7
- DICOMSCP error when a contour has many points HOT 1
- A typo in method bool IsInBounds(Vector3 pt) in RT package
- Anonymization fails for RP-files HOT 1
- Possible leak in DICOMSCU HOT 2
- MaskImageFast Error
- Unable to read Primary Fluence Mode Sequence
- CMove from ARIA to Self - CT Images (EvilDICOM v2.0.6.5) HOT 2
- ReadIndefiniteBigEndian uses LittleEndian for EndOfSequenceItem
- Queue.Anonymize() throws System.InvalidOoperationException HOT 2
- Progress and Roadmap of Evil-DICOM
- Meta/Header information not being written
- Unable to retrieve tag BeamDeliveryDurationLimit (300A,005C) HOT 1
- Is there any tool for writing Dicom-RT structure easily?
- How to delete one structure from loaded DICOM StructureSet
- RTDose CStore error when sending to MIM HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from evil-dicom.