Storage base check_status returns errors instead of raising them about django-health-check HOT 5 CLOSED

Ah, I see that now, thanks! I'm currently writing tests for the storage, cache, and database health checks that mock the backend sources to find that sort of thing if you're interested.

from django-health-check.

I know, I already have a branch that I'm working on, where I refactored it into using raise instead of return. Thanks!

from django-health-check.

@mspeedy yes please!!!

from django-health-check.

Tests are all done! I initially wrote them using the django testing library in my local project, though, so I realized too late they couldn't easily transfer, since you've been using pytest. I added the necessary features to make it a django project in my repo so the tests can run, but I'm not sure how that would work in prod. Let me know what you think should be done.

from django-health-check.

@mspeedy would you mind opening up a PR? That would make reviewing and leaving notes a lot easier. I'm really excited!

from django-health-check.