Code Monkey home page Code Monkey logo

Comments (9)

codingjoe avatar codingjoe commented on July 1, 2024

Do you have a little more information for me?

from django-health-check.

samuelfekete avatar samuelfekete commented on July 1, 2024

It seems that health_check_celery3 calls 'forget' https://github.com/KristianOellegaard/django-health-check/blob/master/health_check_celery3/plugin_health_check.py#L30, which isn't supported by all backends. This results in an error even when Celery is working perfectly fine.

from django-health-check.

codingjoe avatar codingjoe commented on July 1, 2024

@samuelfekete looks like a bug to me. Do you have a solution for it?

from django-health-check.

codingjoe avatar codingjoe commented on July 1, 2024

Contributions are always welcome ;)

from django-health-check.

samuelfekete avatar samuelfekete commented on July 1, 2024

If not all backends support forget, then perhaps result.forget() should be surrounded with a try... except NotImplementedError, which can be ignored.

from django-health-check.

codingjoe avatar codingjoe commented on July 1, 2024

@samuelfekete if you put that into a pull-request and add a test, I'll merge it right away 😉

from django-health-check.

samuelfekete avatar samuelfekete commented on July 1, 2024

Here's the pull-request: #44
@codingjoe if you add tests for the celery3 health check, I'll add a test for this case ;)

from django-health-check.

codingjoe avatar codingjoe commented on July 1, 2024

@samuelfekete that is a good point. I know it's not nice to ask for tests, if there none to extend.
I'll try to make it happen soon.

from django-health-check.

aleksihakli avatar aleksihakli commented on July 1, 2024

I think this can be closed too @codingjoe.

from django-health-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.