Is can_request_send method correct? about django-friendship HOT 8 CLOSED

    if from_user == to_user or FriendshipRequest.objects.filter(
        from_user=from_user,
        to_user=to_user,
        ).exists() is False:

I recommend to use parentheses because it's not clear what is False refers to.

Also, maybe not is better than is False.

from django-friendship.

        if self.can_request_send(from_user, to_user):
            raise AlreadyExistsError("Friendship already requested")

I'm also not sure if this code is correct.

from django-friendship.

It should be

    if from_user == to_user or not FriendshipRequest.objects.filter(
        from_user=from_user,
        to_user=to_user,
        ).exists():

And

if not self.can_request_send:
    raise  AlreadyExistsError (...)

Pardon formatting errors I'm on my phone

If somebody with write rights sees this maybe he can do the commit

from django-friendship.

Is this library still maintained?

from django-friendship.

@hisyatokaku yes the method is correct. I just refactored it a bit to make it slightly more clear.

from django-friendship.

In this case maybe you should just remove is False?

from django-friendship.

#88

from django-friendship.

Is this library still maintained?

Last commit more than 3 months ago. But I'm not sure.

from django-friendship.