Comments (10)
I have to get working on a project right now, but if no one is working on this currently I just read over the thread and would be interested in implementing it. (I'll submit the pull request when I'm done with my OS threading assignment)
from thrive.
You have been assigned :) btw you don't >need< to submit a pull request before you have some code to show, do it whenever
EDIT:
I don't think i have the necessary permissions to add you as a contributor on github (can't find it atleast) so i can't click you as assigned, but no matter, just go for it!
from thrive.
So... I finished rewriting the Storage Organelle class to be generalized and robust, as well as implementing bandwidth and variant compound sizes (everything is set to size 1 for now), and was about to edit the Microbe class to handle these changes when I noticed that the fundamental way that microbes absorbed compounds was defined in the engine... so since I'm going to be modifying agent.cpp ANYWAYS, should I merge this issue with the "rename agents to compounds" issue and just do that while I'm at it? It is making this in to quite a bit more refactoring than I originally anticipated but I'm already halfway there...
Edit: That is to say, the microbe used to call "setCanAbsorbAgent" when a vacuole was added, but since things are now 'generalized storage' that variable is deprecated and 'agent' absorption needs to be changed to reflect that.
ugh, scratch that. I'll split it into two things. I'll just make the microbe call setCanAbsorb for all 3 compound types manually when initialized and let someone else refactor and/or refactor it myself later.
from thrive.
You shouldn't worry about other issues being worked on, unless you would be doing huge restructuring. Just update the cpp/h files to match your new structure.
defined in the engine
We don't actually define everything in C++ to be the 'engine' part, but rather just implement things in the language where it makes more sense, a lot of the lua code should eventually be migrated to C++, but while it's new and experimental there's an advantage to keeping it in lua.
from thrive.
This will be finally fixed in #91
from thrive.
Everything has been fixed except for the empty hex storage, since we currently don't have empty hexes. This should follow from #115.
from thrive.
Technically this doesn't require 115 in any way -- we just make a new "cytoplasm" organelle, and modify the organelle-placement-checks in microbe_editor.lua to remove cytoplasm before placing the new organelle.
from thrive.
True, however I'm not a fan of throwing work at it for an organelle type that will be removed in the not-too-distant future
from thrive.
Thinking on this again it hits me that an empty cytoplasm organelle would probably be the cleanest way to handle this internally, regardless what it looks like to the player. Since I forgot to ask before, why would an invisible-to-player cytoplasm organelle be removed in the not-too-distant future?
from thrive.
replaced by the more relevant #291
from thrive.
Related Issues (20)
- Going to the editor causes 160 new orphaned Nodes each time
- Add interface to TaskExecutor to allow non-allocating tasks to be used
- Floating chunks can spawn inside the player cell colony (which should be prevented)
- Create an icon to represent default organelle state / no upgrade selected HOT 9
- Question HOT 1
- Multicellular ingestion incorrectly checks capacity in lead cell
- Make tutorial lines update the player position more times per second (to reduce jitter)
- Investigate updating GenerateThreadedSystems to not require running through Godot (might be possible with Godot 4)
- Art gallery model viewer light doesn't work correctly when 3D main menu backgrounds are enabled
- Patch extinction GUI is sized wrong
- Add Mucocyst effect
- AI should know how to use the signaling agent to send commands
- AI should be able to sometimes ignore signaling agent commands
- Make endosymbiosis target receive a population benefit
- Add GUI warning if an endosymbiosis candidate is not present in the current patch
- Editor finish button warning badge should have tooltip saying why it is showing
- Editor cancel button focused state has different border rounding compared to the red background
- Test that in-progress endosymbiosis doesn't cause problems when becoming multicellular
- Make Mutations.MutateMicrobeOrganelles and other mutations not throw exceptions
- Add text in organelle unlock conditions popup to mention endosymbiosis option
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thrive.