Code Monkey home page Code Monkey logo

Comments (5)

mavimo avatar mavimo commented on May 18, 2024 2

@JensRantil I'm working on PoC related to use Checks feature with the previous reported approach, I'm going also to investigate if the specified approach do not break any GH policy (we are going to use GH Application to build a "out-of-standard" app 😄)

from reviewdog.

mavimo avatar mavimo commented on May 18, 2024 1

Same here, @haya14busa do you consider to release doghouse as FOSS app?

Alternatively we can move all required settings into reviewdog itself, it need only 3 parameters in order to work:

  • PEM key
  • Application ID
  • Installation ID

Maybe setup can be a bit more complex, but IMHO acceptable, what do you think?
cc/ @JensRantil @haya14busa

from reviewdog.

haya14busa avatar haya14busa commented on May 18, 2024 1

Thanks for the comments.

I'm going also to investigate if the specified approach does not break any GH policy

yes, that's a concern. Maybe it's good to support standalone checker but wondering is it really ok or not.
For example, I may register reviewdog GitHub apps to GitHub market place or https://github.com/works-with, and we should check the policy.

from reviewdog.

JensRantil avatar JensRantil commented on May 18, 2024

@mavimo I think your proposal is the way to go. It's similar to the way bors-ng recommends doing it and has worked for us when we've set that application up ourselves.

from reviewdog.

haya14busa avatar haya14busa commented on May 18, 2024

Now reviewdog can report via Check API if it's running on GitHub Actions. https://medium.com/@haya14busa/automated-code-review-on-github-actions-with-reviewdog-for-any-languages-tools-20285e04448e

from reviewdog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.