Comments (5)
@JensRantil I'm working on PoC related to use Checks feature with the previous reported approach, I'm going also to investigate if the specified approach do not break any GH policy (we are going to use GH Application to build a "out-of-standard" app 😄)
from reviewdog.
Same here, @haya14busa do you consider to release doghouse as FOSS app?
Alternatively we can move all required settings into reviewdog itself, it need only 3 parameters in order to work:
- PEM key
- Application ID
- Installation ID
Maybe setup can be a bit more complex, but IMHO acceptable, what do you think?
cc/ @JensRantil @haya14busa
from reviewdog.
Thanks for the comments.
I'm going also to investigate if the specified approach does not break any GH policy
yes, that's a concern. Maybe it's good to support standalone checker but wondering is it really ok or not.
For example, I may register reviewdog GitHub apps to GitHub market place or https://github.com/works-with, and we should check the policy.
from reviewdog.
@mavimo I think your proposal is the way to go. It's similar to the way bors-ng recommends doing it and has worked for us when we've set that application up ourselves.
from reviewdog.
Now reviewdog can report via Check API if it's running on GitHub Actions. https://medium.com/@haya14busa/automated-code-review-on-github-actions-with-reviewdog-for-any-languages-tools-20285e04448e
from reviewdog.
Related Issues (20)
- fail-on-error=false (or left on default) still exits 1 using Github checks
- `-fail-on-error` doesn't work. reviewdog returns zero as exit code even if warnings are found in input HOT 4
- Does not use REVIEWDOG_GITHUB_API_TOKEN unless REVIEWDOG_SKIP_DOGHOUSE is set
- Can not Work HOT 1
- reviewdog: failed to get merge-base commit: exit status 1 HOT 2
- Tfsec- parse error: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token HOT 2
- 0.15.0 installation fails on Alpine using `go get` HOT 1
- Support --filter-mode=[file/nofilter] in github-pr-review
- Can I use XO with review dog?
- `action-flake8` is broken due to an update in `astroid` HOT 1
- 'github-pr-review' reporter is not making suggestion for blank line addition
- Support for Vale text linter HOT 2
- Bundle related suggestions together
- [BUG] Sarif format not working HOT 9
- fail to run reviewdog: XML syntax error on line 10: expected attribute name in element HOT 1
- 'reviewdog: .git exist but is not a directory' in submodule
- Add support for Azure Devops
- I want to konw which LLM do you uesd HOT 4
- File filter for github doesn't correctly submit comments HOT 3
- Wrong line number is sent to Bitbucket Server Code Insight Reports HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviewdog.