Code Monkey home page Code Monkey logo

Comments (8)

RCGitBot avatar RCGitBot commented on June 12, 2024

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

from purchases-ios.

samkass avatar samkass commented on June 12, 2024

This is the same as my RevenueCat ZenDesk support ticket 36435

from purchases-ios.

NachoSoto avatar NachoSoto commented on June 12, 2024

Thank you for the detailed report! I'll be looking into this shortly.

Were you able to run this using the change in #3649?

from purchases-ios.

samkass avatar samkass commented on June 12, 2024

Hi @NachoSoto, No I haven't been able to do that. But at the end of my report, I did note that I pulled in some of the RevenueCat source code and added my own debugging. Here's my guess: Because iOS automatically adds "CH" to my locale (even when just selecting "German" as the language), and I have English-US as my second language, and RevenueCat only adds the non-locale language at the end... I'm guessing it checks de-CH, doesn't match anything, then checks en-US, and finds the default English Paywall and displays it-- never getting to de. My guess is if I removed English from my language list, that it would display in German.

So really, my language matching preference would be for RevenueCat to let me define base-language localizations of Paywalls (right now it only allows "German (Germany)", but it should allow "German"), then for each entry in the language list, try to match language+region first, and if that fails, try to match just the language, and if that fails, only THEN go to the next code in the list. (Edit to add: this could also be accomplished by adding the language-only locale after each language-region locale in the list, instead of just adding it to the end. So [de-CH, en-US, it-IT] becomes [de-CH, de, en-US, en, it-IT, it])

from purchases-ios.

NachoSoto avatar NachoSoto commented on June 12, 2024

Thanks again for the detailed report!

I believe #3657 should fix this :)

from purchases-ios.

samkass avatar samkass commented on June 12, 2024

Confirmed that 4.36.1 with fix #3657 fixes this issue! Thanks again!

from purchases-ios.

NachoSoto avatar NachoSoto commented on June 12, 2024

Awesome, thanks for the help!

from purchases-ios.

github-actions avatar github-actions commented on June 12, 2024

This issue has been automatically locked due to no recent activity after it was closed. Please open a new issue for related reports.

from purchases-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.