Set minimum value for ReBuffer about revanced-integrations HOT 15 CLOSED

You know how to code, create a PR instead of opening issues.

from revanced-integrations.

Please create detailed issues, nobody will understand these

from revanced-integrations.

You know how to code, create a PR instead of opening issues.

Creating an issue is fine, it should be done properly or its useless.

from revanced-integrations.

You know how to code, create a PR instead of opening issues.

@oSumAtrIX wants issues before PRs. It seems like there's a misunderstanding here between the two of you..?

from revanced-integrations.

No, an issue in itself is fine as well. It is part of the workflow and also complete without a PR.

from revanced-integrations.

A PR on the other hand is not complete without an issue in the first place (Issue -> discuss -> PR)

from revanced-integrations.

This already been fixed on last Vanced 17.03.38.

Has this bug been reintroduced into the ReVanced rewrite or has it been fixed already?

from revanced-integrations.

You know how to code, create a PR instead of opening issues.

Code is yours, and I don't want to place something where it's okay for me but not for you.

Anyway I edited the issue to be more clear.

from revanced-integrations.

You know how to code, create a PR instead of opening issues.

Code is yours, and I don't want to place something where it's okay for me but not for you.

Anyway I edited the issue to be more clear.

Can you explain the issue, how it is related, where it originates from, and a possible solution?

from revanced-integrations.

This already been fixed on last Vanced 17.03.38.

Has this bug been reintroduced into the ReVanced rewrite or has it been fixed already?

@TheJeterLP seems to have set the minimum value to 0, and not to 1. But I'm not totally sure.

from revanced-integrations.

You know how to code, create a PR instead of opening issues.

Code is yours, and I don't want to place something where it's okay for me but not for you.
Anyway I edited the issue to be more clear.

Can you explain the issue, how it is related, where it originates from, and a possible solution?

I already explained as well as possible.

if a value lower than 1 is set for the ReBuffer settings, this too low value always crashes the app. Because app can't buffer anything with a value lower than 1.

About solution...I don't think that I need to write it down.

from revanced-integrations.

Can you explain the issue,

https://github.com/revanced/revanced-integrations/blob/7de199421c37b3fd77488f60bbd5d492e3bd810e/app/src/main/java/app/revanced/integrations/patches/VideoBufferPatch.java#L15-L17
getReBuffer must always return 1 or higher, otherwise, the application will infinitely crash because the application can't buffer anything with a value lower than 1.

how it is related, where it originates from

This issue used to be in Vanced. It was fixed in Vanced 17.03.38 but may have been reintroduced now with the rewrite (otherwise, why would this issue be made in the first place?).

and a possible solution?

By coercing the value to at least 1.

from revanced-integrations.

To be more specific. I'm referring to these values:

from revanced-integrations.

but may have been reintroduced now with the rewrite (otherwise, why would this issue be made in the first place?).

Purrrfect!

P.S: Was placed there because the original modder never thought it could happen...or because he didn't care.

from revanced-integrations.

Fixed

from revanced-integrations.