AI player doesn't build fisheries. about s25client HOT 2 CLOSED

After some debugging and testing I found that code in method AIResourceMap::findBestPosition(const MapPoint& pt, BuildingQuality size, unsigned radius, int minimum) in AIResourceMap.cpp never go past the condition
if(!aiMap[idx].reachable || !aiMap[idx].owned || aiMap[idx].farmed) continue;

That is completely fine: It tries to find a position for building a fishery not a fish position. See the next line that checks the BQ of that point:

The issue here is that the calculation of the AI ResourceMaps has a serious bug. Specifically the incremental update which is intended to save computation time is wrong and likely the initial computation is too (that part that uses the previously calculated value)
I always wanted to write a good test for that and fix it for good which should make the AI much better as it is currently running with an immense handicap.

See the original issue for more details: #933 Closing this as a duplicate

from s25client.

Thanks for the clarification! I'll take a closer look on the original issue.

from s25client.