Store.ActionCreator , Store.AsyncActionCreator and Middlewares about reswift HOT 4 CLOSED

As far as I understand, all overloads of Store.dispatch that using both Store.ActionCreator and Store.AsyncActionCreator types wrap _defaultDispatch actually. It seems like a job for middlewares, isn't it?

Generally this would be a job for middleware. However, there are two specific reasons we have chosen to implement them as separate methods on the store:

1. Some of the overloads change the API of dispatch by taking a callback as an additional argument - this cannot be accomplished by middleware
2. We want to provide some features, such as dispatching ActionCreators or having a way to be notified about the completion of an AsyncActionCreator by default. We don't want that developers need to add middleware for these essential features. That means this library will be more opinionated than Redux, but that was a conscious decision on our end.

An additional note on 2., we are looking for a better default way for async in ReSwift and we'll have the discussion under #64. AsyncActionCreators work for now but we are hoping to find a better solution.

Lastly:

BTW, why does Middleware take references to dispatch and getState separately? Maybe it is worth to extract both from StoreType to some StoreCoreAPIType and pass it by weak reference.

I think in this case it's not worth introducing a new type. We are borrowing the middleware API from Redux (which makes it easier for some folks to understand the mechanism) and I would only want to deviate from it if we can add significant value. I don't think that's the case for this suggestion.

Thanks a lot for contributing your questions & ideas 👍

from reswift.

@Ben-G Thanks for your detailed explanation.

from reswift.

Some of the overloads change the API of dispatch by taking a callback as an additional argument - this cannot be accomplished by middleware

Actually I have a question about this too :) I perfectly understand the value of that callback for asynchronous version of dispatch and don't see any profit to use it on synchronous ones. It leads to pyramid of doom. Is it all about consistency of dispatch overloads?

from reswift.

I agree on the latest comment. The callbacks on the synchronous dispatch methods don't make a lot of sense. They were added for consistency but don't add a lot of value. We should likely remove them soon! You are right that they encourage to use the library in an undesirable way.

from reswift.