Comments (3)
meh, not fixing.
from node-restify.
If you're making changes to request/response 's prototype, doesn't that mean you could conflict with other libraries that do the same thing? I realize that using express with restify is probably something no sane person should ever do, but I could imagine a scenario, say, where a testrunner for several projects (some of which use Restify, some of which use Express) would run into problems because different tests would require express and restify and mess up the prototype.
Full disclosure: the "hypothetical" scenario described above is actually a problem I'm currently trying to solve.
from node-restify.
Yes, it does. Unfortunately, this is the cost of v8. Once upon a time, I
did the "right thing" and wrapped it all, using getters/setters on the
properties. restify was 15-20 times slower than now (a trivial echo
server peaked at about 250-300 requests/second). So the short is, it's
lame, and it sucks, but it is what it is, and this just what it has to be
:.
On Thu, May 2, 2013 at 5:38 PM, Tim Jarratt [email protected]:
If you're making changes to request/response 's prototype, doesn't that
mean you could conflict with other libraries that do the same thing? I
realize that using express with restify is probably something no sane
person should ever do, but I could imagine a scenario, say, where a
testrunner for several projects (some of which use Restify, some of which
use Express) would run into problems because different tests would require
express and restify and mess up the prototype.Full disclosure: the "hypothetical" scenario described above is actually a
problem I'm currently trying to solve.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-17373368
.
from node-restify.
Related Issues (20)
- package.json's "engines" says `"node": ">=10.0.0"` but actual base version is v14.18.0 HOT 2
- Upgrade formidable dependency to resolve npm warning HOT 1
- New async/await handler support breaks `next(false)` functionality in current async handlers HOT 16
- ResourceNotFound with parameter length greater than 100
- Error when response already destroyed
- Using return in Async handlers logs entire response object to stdout HOT 4
- Allow overriding log in `plugins/audit`
- socket close on request done ?
- prePath middleware strips multiple slashes to an empty string
- An odd request can crash the process when `restify.pre.sanitizePath()` is used
- Does officially support Nodejs V18? HOT 1
- request/response serializers behave incorrectly for auditLogger plugin and Bunyan logger HOT 1
- handler error when running benchmark
- Is this repo actively maintained ?
- Restify support for nodejs v20 is merged but not released HOT 5
- Is restify.plugins.bodyParser's maxBodySize setting actually doing anything?
- v11.2.0 is not available at NPM HOT 4
- Migration from 8.5.1 to 10.0.0 causing issues
- bunyan is unmaintained, move to pino?
- Res.redirect won't work for async routes at all?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-restify.