Comments (5)
Notice that libraries have a common validation script, where we may introduce rules that guarantee that a library fulfills with certain specifications. I.e. any library must call the method SetLibraryVersion
at InitProcess
method.
validateLibrary:
stage: pre-build
script:
- python3 pipeline/validateLibrary.py .
except:
variables:
- $CRONJOB == "YES"
Then, we are also executing the clang-format
validation at each repository. This job is not executed at any pipeline, but it is executed only from time to time, it is defined as an scheduled job. It will be launched every week (or day), check if there are any files that do not fulfill with the clang-format specifications, prepare the commit and upload it to the repository.
clang-format:
stage: pre-build
script:
- echo "**$CRONJOB**"
- echo "**$CI_SERVER_HOST**"
- cd ${CI_PROJECT_DIR}/pipeline/clang-format/
- ./clangformattest.sh
# We execute only at a schedulled pipeline that defines CRONJOB variable
only:
variables:
- $CRONJOB
from framework.
I have created a milestone and linked issues for the other repositories, it would be nice if we could reference the milestone from the other repos too, (otherwise it makes little sense).
Maybe @jgalan or @juanangp know more about this?
from framework.
So, every library validation pipeline should include clang-format
, validateLibrary
, build
and loadRESTLibraries
tests.
Then, I created issues for those libraries that already include tests on top of those basic/common ones, and edited this issue in concordance.
from framework.
For the moment, most libraries only implement build
, clang-format
and library validation
. But rawlib
and axionlib
are already implementing few dedicated tests. So I have added a explicit issue for them.
Also, I see that restG4
does not implement clang-format
in its pipeline.
from framework.
For the moment, most libraries only implement
build
,clang-format
andlibrary validation
. Butrawlib
andaxionlib
are already implementing few dedicated tests. So I have added a explicit issue for them.Also, I see that
restG4
does not implementclang-format
in its pipeline.
You are right, this should be updated.
from framework.
Related Issues (20)
- Problem in schema evolution for processes. CheckByteCount warning/error HOT 10
- Avoid code duplication for signal processing HOT 14
- Processes streamer input/output requires deep review
- Add a fix to solve few problems that may led to an invalid XML
- Framework pipeline triggers submodule pipelines
- Implement pre-commit checks in each submodule based on framework implementation
- The GEOM_SCALE identifier in TRestEveEventViewer.h causes wrong scale in visualization HOT 4
- Removing detectorlib dependencies inside rawlib HOT 11
- Update the way cuts are introduced inside `TRestDataSet` so that we can use `TRestCut`.
- TRestDataSet does not read the date/time properly if time is not given.
- Bug when processing files with a single event
- Properly uninstalling the files from previous installation HOT 1
- Validating submodules with their corresponding branch HOT 1
- Cling errors when loading REST libraries in a restRoot session HOT 2
- Automatic PR at framework after submodule PR HOT 6
- GitHub Actions framework cache not working as expected
- Update CI Docker Image to official REST-for-Physics image
- Update CI Docker Image to official REST-for-Physics image
- MacOs installation issue, libraries should be placed at `bin`.
- MacOs installation issue. Libraries should be copied to bin. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framework.