Comments (10)
@steveklabnik thanks! Re-ran the CI and it looks like we're good to go on head for almost everything. Got something new to look into but at least the issues here seem resolved. Really appreciate it!
from resque.
@level_override
is set in Logger#initialize
. The only thing that comes to mind that could cause this is someone is overriding Logger#initialize
and not calling super
.
from resque.
Thanks @yahonda. I'll probably bump the mono_logger
dependency once there's a new release on rubygems in a 2.6.x release so that we have baseline ruby 3.3 support.
from resque.
Good tip @jeremyevans. I think I've found (and tentatively fixed) it: steveklabnik/mono_logger#12
from resque.
https://github.com/Shopify/job-iteration/actions/runs/4185456672/jobs/7252537151 now passes with Ruby HEAD & my branch of mono_logger
, which is where I noticed the issue.
from resque.
Thanks for the fix.
Confirmed steveklabnik/mono_logger#12 addresses this issue
by setting Gemfile as follows.
$ git diff
diff --git a/Gemfile b/Gemfile
index b78f7439..cbb5bde5 100644
--- a/Gemfile
+++ b/Gemfile
@@ -15,3 +15,4 @@ gem "rack-test", "~> 2.0"
gem "rake"
gem "rubocop", "~> 0.80"
gem "pry"
+gem "mono_logger", github: "sambostock/mono_logger", branch: "ruby-head-support"
$
from resque.
Also confirmed adding this to rails Gemfile fixes the Active Job tests on Ruby 3.3.0 🙏
from resque.
If I'm understanding this correctly, this was resolved in mono_logger
. Any objection to closing out this issue?
from resque.
Correct. Closing this issue. Thank you for the notification.
from resque.
@PatrickTulskie shipped 1.1.2, you should be able to update, let me know if you run into any more issues.
from resque.
Related Issues (20)
- Make the signal for child termination configurable HOT 1
- Workers not terminating as expected HOT 1
- resque-status is not compatible with Resque > 2 HOT 2
- Experiencing a lot of database overhead with forked jobs HOT 3
- deadlock during deallocation of threads and fork
- [feature request] filter sensitive args in resque server
- DirtyExit VS PruneDeadWorkerDirtyExit - what is the difference? HOT 1
- USR2 signal is happening but my resque job is going to dirty exit HOT 2
- start_heartbeat can die while worker is still running HOT 1
- Unpatched CVE-2022-44303 - Reflected XSS HOT 4
- Please publish security advisories for XSS vulnerabilities HOT 4
- Search Feature in failed jobs HOT 2
- Cannot use with Rack 3.0 because of Sinatra (resque-web); Blocked upgrade to Rails 7.1 HOT 6
- Ruby 3.3 and stuck workers. HOT 28
- Autoscaling resque question HOT 2
- Overview UI Broken Due to Nonce Whitelist HOT 2
- Code & comment for redis initializer method could be clearer
- Is it possible to fail a job without raising an exception? HOT 1
- Resque logo suggestion
- Implement Active Job adapter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from resque.