Not compatible with jetpack about wp-tevko-responsive-images HOT 6 CLOSED

Looking forward for this release too. Thanks.

from wp-tevko-responsive-images.

Looks like there are two different cases we need to be aware of with Jetpack's Photon module:

Content images: Photon doesn't affect images being added to content, but instead adds a filter to the_content that finds all images in a post and swaps out the src attribute for the photon url when they are displayed on the front end. (FWIW, the code for that filter is pretty nice and could be useful when we filter sizes attributes in the content).

Template images: When we're building image tags on the front end—for a featured image or any other manually generated image tag—Photon is filtering image_downsize(), which is what wp_get_attachment_image_src() uses to return an array containing the url, width, and height of an image. We use the width and height information to determine srcset candidates. However, Photon's filter returns a url string for the url and false for the height and width attributes that we need. We could shim this on our end, which is what the suggested patch from the support forum linked above does, but ultimately I think this is a bug with Photon and we should reach out to them with a fix for their filter.

from wp-tevko-responsive-images.

@joemcgill agreed. Let's raise an issue in slack tomorrow

from wp-tevko-responsive-images.

After talking this through with the JetPack team, they are intentionally returning falsey values for height and width and they're not likely to fix this. Additionally, they're handling a lot of the optimizations that we are providing on their end, so we really don't need to worry about adding support for Photon in srcset attributes. For those reasons I think we can close this issue.

from wp-tevko-responsive-images.

Thanks for the info Joe, but just to make this clear, does Photon makes this plugin redundant and they should not be used in conjunction?

from wp-tevko-responsive-images.

In some ways, it seems that way, yes. In the mean time, I wouldn't recommend using them together since Photon is generating optimized image sizes for you on the fly. I'll keep my eye on this issue and will update it with any best practices we learn.

from wp-tevko-responsive-images.