Code Monkey home page Code Monkey logo

Comments (6)

mishranurag avatar mishranurag commented on May 28, 2024

Tim, could you please try adding analysis dates in the EXS file and let me know if that solves the problem?

Thanks
~A

from basins.

timcera avatar timcera commented on May 28, 2024

Here is my current, unedited, exactly as WinHSPF 3.1 made it '03060101-RCH7.exs' file.

03060101-RCH7.zip

I see I could adjust the dates in line 3, however, that is missing the point. The computer should do things for me and if it can't should error - not present and use incorrect calculations. Either WinHSPF should create a better '*.exs' file or HSPEXP+ should uniformly adjust start and end dates.

My feature request would be from most desirable to least:

  1. HSPEXP+ would correctly handle all missing values in the observation record for all calculations.
  2. HSPEXP+ would adjust analysis start and end dates to match the observed record for all calculations. If there are missing observed values in the analysis period HSPEXP would warn and/or error.
  3. WinHSPF would adjust calibration start and end dates to match the observed record when building the *.exs file.
  4. Whether 3 is implemented or not, at a minimum HSPEXP+ should warn or error if there are missing values in the observed data set. This is a minimum I think because right now, incorrect statistics are reported and used for development of advice.

from basins.

mishranurag avatar mishranurag commented on May 28, 2024

I agree with you Tim. I made changes to the code and implemented your most desirable option. I will try and make an executable and post it.

from basins.

timcera avatar timcera commented on May 28, 2024

Wow! That is great! Thanks!

from basins.

mishranurag avatar mishranurag commented on May 28, 2024

There was still an issue in limiting the expert calculation when observed data ended before the simulated data. I fixed that today and it will be available in the next version.

I will keep this issue open, in case the results do not come out as expected.

from basins.

mishranurag avatar mishranurag commented on May 28, 2024

The number of years calculated for expert statistics rounded to an integer. This skewed calculations for very short calibration period. This issue has been fixed for future releases.

from basins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.