Comments (5)
Hi @MichielDeMey the transform
function is actually your best friend. As you see in the tests you may either return a rejected promise or throw an Error
inside the transform
function.
You can also pass the transform
function to .defaults(...)
which then hopefully meets your DRY goal.
Let me know if this solves what you need.
from request-promise.
Hey @analog-nico
This is exactly what I needed!
One minor downside is that we have to create a new Promise and reject that one instead of having a reference to the promise itself which we can reject. But I can live with that small overhead.
Now I just have to figure out the following error thrown by Request:
(This error is thrown both by using the rejected promise and throwing a new error)
Possibly unhandled Error: [error message here]
Which is discussed here: https://github.com/petkaantonov/bluebird#error-handling
from request-promise.
Great!
You may just throw the Error inside the transform function and you won't have the overhead of creating another promise.
The "Possibly unhandled Error" is printed if you don't call .catch(...)
or call it too late.
from request-promise.
I've decided to just throw the Error in order to avoid the overhead of creating a new Promise.
Thanks!
from request-promise.
You are welcome!
from request-promise.
Related Issues (20)
- Proper way to do retry logic
- How to transform response headers?
- Produces warning for jest 25.5.0
- Uploading file with metadata using unirest js api causing trouble when sending data
- How to curl --http 1.0 in request-promise
- 如何请求图片,返回的数据如何处理呢 HOT 1
- Hey @pradiptabasu , you need to install `request` yourself before you install `request-promise`. See the [installation instructions](https://github.com/request/request-promise#installation).
- error message RequestError: Error: Invalid URI "xxxxxxxx",how to deal it?
- Error: Client network socket disconnected before secure TLS connection was established HOT 3
- Including this library will drag a ton of deps/files... sad
- Error: EPERM: operation not permitted, read
- Terminal
- read timeout
- How to see the request of a failed request ? HOT 3
- WeChat Mini Program can't support 'promise' grammar
- requestpromise
- ignore proxy signed certificate(ssl) issue in request-promise HOT 1
- The "request" library is not installed automatically anymore.
- Request/request-promise
- Issue on a dependency - CVE-2023-26136 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from request-promise.