Code Monkey home page Code Monkey logo

Comments (12)

analog-nico avatar analog-nico commented on July 28, 2024

Hi @mgenev, I see your point. Theoretically, though, all a user has to do is to go to the Request README because Request-Promise exposes the same API. In any case since you had a bad experience with the docs certainly others do, too.

Since you have fresh eyes: In which section of the README would you expect a link to the Request README? In particular I would link the request options section. If that wouldn't be good enough what would you expect from the docs?

from request-promise.

soplakanets avatar soplakanets commented on July 28, 2024

+1 for info on how to send data in docs. This is simply a one additional line, right?

from request-promise.

analog-nico avatar analog-nico commented on July 28, 2024

Hey guys, I updated the post example in the README. However, since @mgenev found the docs being awful I would appreciate your feedback on how to improve them.

from request-promise.

soplakanets avatar soplakanets commented on July 28, 2024

Haha, I wouldn't say they are awful :)

Thanks!

from request-promise.

analog-nico avatar analog-nico commented on July 28, 2024

;D

from request-promise.

mgenev avatar mgenev commented on July 28, 2024

Here's a good example https://visionmedia.github.io/superagent/

I knew how to post right away :D

from request-promise.

yankeeinlondon avatar yankeeinlondon commented on July 28, 2024

One thing I found missing was how to set header variables. I imagine this is a very common requirement and I even suspect there's a very easy way to do it but it was not revealed in the docs. :)

from request-promise.

analog-nico avatar analog-nico commented on July 28, 2024

@ksnyde Thanks for the tip. I will mention that in the next version of the docs. BTW, all docs of Request are valid for Request-Promise, too. So setting headers is the same.

from request-promise.

yankeeinlondon avatar yankeeinlondon commented on July 28, 2024

yeah in the end I did assume that was the case but busy people are stupid people so being explicit pays off more times than not :)

from request-promise.

analog-nico avatar analog-nico commented on July 28, 2024

+1

from request-promise.

analog-nico avatar analog-nico commented on July 28, 2024

I just released 1.0.0 and with that overhauled the README. Thanks for the feedback all you guys! Let me know if can improve something further.

from request-promise.

mgenev avatar mgenev commented on July 28, 2024

perfect thanks a lot!

from request-promise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.