Failing test about request-promise HOT 8 CLOSED

It boils down to line 9:

var c = defaultOptions, i;

Only the reference to the defaultOptions object is assigned to c. Since c is manipulated defaultOptions is too.

Would you mind introducing lodash? Then we could fix the bug changing the line to:

var c = _.cloneDeep(defaultOptions), i;

from request-promise.

@tyabonil Since the bug seemed to also influence issue #21 I fixed it with using lodash. If you don't like lodash as an additional dependency I can remove it and just write vanilla code.

Can you publish the new version? (Alternatively, you could just type npm owner add analog-nico request-promise into your terminal if you are willing to do so.)

from request-promise.

@tyabonil Sorry, I just screwed up. I did not see your update 3 hours ago. Give me a few minutes and I will revert to your version in which you already fixed the bug.

from request-promise.

I am confusing for sure. ;)

This bug got introduced with pull request #16. I thought you fixed it in your merge. However, that was just the code prior to pull request #16. So I don't revert my last commit.

from request-promise.

Thanks, see you copied the object and all looks good. Added a test where we pass a new options object, use 'url' instead of 'uri'

from request-promise.

@analog-nico Added you to npm

from request-promise.

Thanks a lot!

from request-promise.

Fix went into v0.2.4.

from request-promise.