Code Monkey home page Code Monkey logo

Comments (7)

wei avatar wei commented on September 3, 2024

Fixed

pull-request/action.yml

Lines 52 to 54 in 992f4d7

runs:
using: 'docker'
image: docker://ghcr.io/repo-sync/pull-request:v2.8

from pull-request.

tegorov avatar tegorov commented on September 3, 2024

@wei thanks, but you fixed only the first problem.
This pr #90 fixes the second problem.

from pull-request.

wei avatar wei commented on September 3, 2024

Can you elaborate and provide reproduction steps?

causes some problems with the files in future runs

from pull-request.

tegorov avatar tegorov commented on September 3, 2024

Can you elaborate and provide reproduction steps?

When a container runs, it uses the root user by default, that new files created in a container will be added to a runner with root user permissions.
After the first run, next runs will fail at this step:
- uses: actions/checkout@v3
because a runner is using a different user (not root) and can not clear files with root permission (git clean)

jobs:
  pull-request:
    runs-on: [ self-hosted, Linux ]
    steps:
    - uses: actions/checkout@v3
    - uses: docker://ghcr.io/repo-sync/pull-request:v2.8 
      with:
        destination_branch: "main"
        github_token: ${{ secrets.GITHUB_TOKEN }}

from pull-request.

chosten avatar chosten commented on September 3, 2024

Same problem here, the workflow cannot run twice. Second run fails to delete files created with the root user by the first run.

from pull-request.

wei avatar wei commented on September 3, 2024

The permission issue with self-hosted runners is a general issue that happens to all docker based actions on self-hosted runners.

You can find discussions, solutions, and provide feedback at actions/runner#434

I'm going to mark this as a wontfix for now but open to revisit in the future.

from pull-request.

wei avatar wei commented on September 3, 2024

Added a section to README: Docker Container Image Usage

from pull-request.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.