Comments (5)
Looks like some of the support is in the 'master' branch (bc20ace). Is that enough?
Is it related to the table-escape branch? Should the latter be a separate ticket?
from pg_reorg.
Read the above ML thread. Very strange the issue is not repeatable. I wanted to add a test for it but as reported it doesn't normally show.
from pg_reorg.
I think the table-escape branch was mostly a mistake on my part -- I was making the same mistake as the recent poster here:
http://comments.gmane.org/gmane.comp.db.postgresql.bugs/30872
assuming that pg_reorg should be handling escaping of table names passed to the program, when in fact it is standard (if undocumented) for such utilities to assume you have escaped the table name already. I haven't double checked, but we might be able to just get rid of the table-escape branch if there are no other fixes in it.
About the bug with the column name ("order") not being escaped -- yeah, the unreproducibility was kind of mystifying. I think the fix in bc20ace is pretty reasonable/safe, though.
from pg_reorg.
I deleted the table-escape branch, after checking that there were no useful commits there which needed to be merged into master. AFAICT pg_reorg's table escaping, particularly the interpretation of the --table argument, works the same as similar Postgres tools, such as clusterdb.
from pg_reorg.
The fix is both in maint 1.1 and master.
from pg_reorg.
Related Issues (20)
- Concurrent index builds using multiple connections HOT 1
- Support for PostgreSQL 9.2 HOT 2
- Drop support for PostgreSQL 8.2 HOT 6
- Consistency check between program and library HOT 2
- Compile warnings about appendStringInfoVA and appendStringInfoVA_s HOT 4
- Don't wait for READ COMMITTED transactions to finish
- Would it be possible to use pg_reorg to change tablespace? HOT 1
- Improve cleanup/error handling
- Support multiple --table arguments
- Drop USE_PGXS from Makefiles HOT 1
- reorg_drop() with nonexistent OID causes crash HOT 3
- Add DURATION to debug logging.... HOT 4
- pg_reorg may choose a partial index as primary key
- storage parameter on TOAST table gets lost
- Document exit status codes in wiki
- Print status message while waiting on table lock HOT 1
- Trigger to prevent TRUNCATE on target table
- Concurrent DDL guard? HOT 4
- Deal with invalid indexes HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pg_reorg.