Comments (3)
Hi Pat,
I would probably just test that the mandrill_mail
method is receiving the correct args (mocks/stubs). This gem has tests that test if the Mandrill gem is receiving arguments from the mandrill_mail
method, so there is no sense in re-testing that again. You should just assume that if you give mandrill_mail
the correct arguments they'll get to where they need to go.
If you realllllllyyy want to go that far you can look at https://github.com/renz45/mandrill_mailer/blob/master/lib/mandrill_mailer/template_mailer.rb#L192. This gem is really just a wrapper for the actual mandrill gem, it adds a few things that makes it easier to use. You could just stub/mock Mandrill::Messages
to test that the correct attributes are getting passed to the send_template
method.
I still wouldn't test the actual request being made (with something like VCR), at that point you're doubling up on tests from the Mandrill gem.
from mandrill_mailer.
Hi Adam
Thanks for the feedback - though, I've no desire to stub things out, given they're acceptance-level tests (I certainly stub out the mailer for unit tests). I may investigate adapting the mandrill gem to have a test mode that stores requests but doesn't send them through (much like ActionMailer::Base.deliveries
).
from mandrill_mailer.
Closing since this was merged ;)
from mandrill_mailer.
Related Issues (20)
- Template defaults overridden HOT 6
- Suggestion: Interceptor should accept return from proc HOT 2
- assets precompile error HOT 11
- Interceptor Proc params string symbol discrepancy HOT 1
- Delay throwing warning in test_setup_for blocks if email option is missing HOT 4
- vars do not serialize properly when using deliver_later HOT 2
- Amazon SES HOT 3
- problem with template_content key in mandrill_mail(args) HOT 3
- dependent on json-1.8.3? HOT 4
- Optionally not encode attachments and images HOT 1
- Call render_to_string from MandrillMailer::TemplateMailer HOT 1
- Rails 5 support HOT 3
- Attachment not included in mail, yet no errors raised HOT 2
- Not working with rails 5 HOT 5
- Sending through array day as merge_vars HOT 1
- Optionally use 'mandrill_mailer/offline'
- Empty emails HOT 1
- Version 1.8.0 not available on RubyGems HOT 2
- Reject Error
- Unsigned error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mandrill_mailer.