Publish new release about github-action HOT 8 CLOSED

Good one! I've been releasing this by pushing a certain commit to the master branch that in turn triggered the release workflow. As we can't commit directly to master.

We should have a new mechanism of making releases. We could use the same one you guys use in renovatebot/renovate. What do you think and if the same as renovate, how does that work exactly cause I only saw the workflow with repository disptatch as trigger?

from github-action.

I think we should use the same idea as in our helm chart. So release for every renovate version and let them match.

from github-action.

I've took a quick look at helm-chart, but the way that is configured would mean that we make a release on every push to master right?

from github-action.

I don't see how that is set up to matching the Renovate version. If we release on every push to master, than how would the Renovate version be matched for commits other than Renovate. I think releasing for every version of Renovate is a great idea but am not sure about matching up the versions.

from github-action.

Yes, we can skip publish or overwrite existing versions.

My preference would be skip.

from github-action.

I'm strongly against overwriting tags as that could mess up repo's using this action and should IMHO be considered usecure.

What are you then suggesting exactly, the following as our release strategy?

• On a commit to master that is a Renovate update (i.e. commit message starts with fix(deps): update renovate/renovate docker tag to ) we trigger the release workflow.
• We get the version from the commit message (i.e. v19.228.2) and publish our release with that same version.
• The release workflow updates the the changelog etc. and creates a release for this action, matching the Renovate version.

One thing that comes to mind, but is not a blocking issue IMHO is the following.

• When we make changes we have to wait for a new Renovate version to be released before the changes are released.
  Based on how often I've seen Renovate being released in the past I don't think that should be a huge problem.

Did I understood this correctly? If so, I can agree with this strategy and think I can work up something like this fairly quickly :) BTW I'm currently working on converting this action to TypeScript!

from github-action.

Yes. For current docker action we can simply read the version from dockerfile and check if git tag exists.

from github-action.

That is a good one! I'll likely PR the conversion to TypeScript today, in which the Renovate version is in a TypeScript file (updated by a regex manager). I could just add a function to get the version, which we can use for making the releases.

Why should we check if a git tag exists? Do you mean whether the tag exists in the renovate repo, cause that tag must already exist since that would have triggered a version update here, right?

from github-action.