weird behaviour, newline in $path about data-dpath HOT 20 OPEN

hi, any updates on this?

from data-dpath.

Sorry, I lost momentum. I can reproduce it, though.

from data-dpath.

Let me write notes here.
It's the path parser's fault, which creates the path steps. In the first phase it correctly creates them:

$VAR1 = [
          bless( [
                   'ROOT',
                   ''
                 ], 'Data::DPath::Step' ),
          bless( [
                   'KEY',
                   'details',
                   '[ value eq \'foo bar baz\' ]'
                 ], 'Data::DPath::Step' )
        ];

In the contained-newline case it only searches for the root node:

$VAR1 = [
          bless( [
                   'ROOT',
                   ''
                 ], 'Data::DPath::Step' )
        ];

Let me think about it...

from data-dpath.

Missing regex options /s to handle multilines when parsing [filters] in lib/Data/DPath/Path.pm. Now I just need to recover from the merge mess I created in this repository to apply this fix.

from data-dpath.

Please check if v0.58 fixes this for you, too. If not, please reopen this issue. Thanks for reporting and especially preparing the minimalistic example code.

from data-dpath.

hi and thanks for the patch, please see my test case and tell me what you think about the behaviour im testing.

from data-dpath.

im not sure this is the correct behaviour. the path says that we are looking for a value that includes a newline. your fixed code however returns something even though a node with such a value does not exist. the test should make this clear.

from data-dpath.

Thanks. I already extended the tests for the corresponding fix in t/regressions.t, see 52d9b6a - but we can certainly make it a dedicated test if you prefer.

from data-dpath.

oh, my bad, you can do however you want with the PR.

from data-dpath.

Ah, you mean the fix is not yet correct and your test shows that better? I will have a deeper look later then.

from data-dpath.

exactly.

from data-dpath.

Ok, I will look at it later. :-)

from data-dpath.

any news?

from data-dpath.

sorry for being persistent but since the ticket is closed I am afraif you will loose track unless I keep bumping this up.

from data-dpath.

hi, just curious, if anything happend in the last months.

from data-dpath.

still curious over here. :)

from data-dpath.

...and still exhausted here, sorry, I simply don't have a contiguous block of spare time hours available to focus and concentrate.

from data-dpath.

thats okay, hope you are doing well. :)

from data-dpath.

Is there anything I can do to help out?

from data-dpath.

You could simply doing the actual debugging on your own. Your distance to the code is not greater than mine after the years. I ran out of energy. In that particular case I even exhaust by understanding which part of the string escaping in the unittest is about escaping whitespace to which layer of the problem. I only have a huge black dontcare in me and even tend to simply declare that dpath is just made for non-newline-problems only. Sorry.

from data-dpath.