Code Monkey home page Code Monkey logo

Comments (7)

github-actions avatar github-actions commented on June 5, 2024

This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up.
Thank you for contributing <3

from nodemon.

EldTM avatar EldTM commented on June 5, 2024

@remy ^Bump

from nodemon.

remy avatar remy commented on June 5, 2024

This has been raised before, and inline with the design principle of fewer features, it's been agreed that it wouldn't be added.

Perhaps if you can elaborate on "I'm already aware of the possibility of CTRL + C, but it has certain limitations" - what limitations are they?

My understanding is ctrl+c is send a kill signal and thusly the chain of processes should shutdown. Certainly nodemon isn't doing anything more than that in the code, sending a kill signal to the subprocess. Adding a "exit"/"q" key would do the exact same thing…

from nodemon.

EldTM avatar EldTM commented on June 5, 2024

My idea was the possibility of a shutdown/cleanup hook function on the one hand that if possible could be made to be more graceful in shutting down the processes and/or doing additional cleanup work.

The other, main concern was that there were suggestions that the nodemon can spawn multiple instances while restarting due to lack of proper cleanup (graceful shutdown) on Windows. I expect CTRL+C is more effective on linux/nix. If you're sure that CTRL+C properly cleans up everything and doesn't leave a zombie nodemon after itself, then I have no more concerns regarding that part of my rationale.

from nodemon.

remy avatar remy commented on June 5, 2024

It's not quite that simple. What's happening when you send ctrl+c, is that nodemon is trapping the signal then doing a controlled shutdown of the spawned process, then trying to work out if it actually shut down, and then nodemon exits itself.

So you see, adding support for an arbitrary command to shut down is no different to ctrl+c, and the result is the same. Zombies will occur, sometimes, but it depends entirely on the system and the software.

I hope that clarifies a bit.

from nodemon.

github-actions avatar github-actions commented on June 5, 2024

This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up.
Thank you for contributing <3

from nodemon.

github-actions avatar github-actions commented on June 5, 2024

Automatically closing this issue due to lack of activity

from nodemon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.